-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Helm installation method #3989
Add documentation for Helm installation method #3989
Conversation
2ac1383
to
3fb3278
Compare
216bb3b
to
1ab56f0
Compare
1ab56f0
to
784d187
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits.
to these CRDs). CRDs defined this way will also never be deleted (to avoid | ||
accidental deletion of user-defined CRs) and will also never be upgraded (in | ||
case the chart author didn't ensure that the upgrade was | ||
backwards-compatible). The rationale for all of this is described in details in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this -> these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's "this" here
Fixes antrea-io#2641 Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
784d187
to
c3d3e89
Compare
/skip-all |
Codecov Report
@@ Coverage Diff @@
## main #3989 +/- ##
=======================================
Coverage 64.39% 64.39%
=======================================
Files 295 295
Lines 43781 43781
=======================================
Hits 28191 28191
Misses 13304 13304
Partials 2286 2286
|
Fixes #2641
Signed-off-by: Antonin Bas abas@vmware.com