Implement Network Policy rule reconciler #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Add one of the following comments to continue: |
tnqn
force-pushed
the
networkpolicy-reconciler
branch
from
99793ac
to
dd04612
Compare
jianjuns
reviewed
Nov 14, 2019
| } | ||
|
|
||
| r.Lock() | ||
| defer r.Unlock() |
There was a problem hiding this comment.
Do we need defer for such cases?
There was a problem hiding this comment.
Changed to use sync.Map, PTAL.
tnqn
force-pushed
the
networkpolicy-reconciler
branch
2 times, most recently
from
999c277
to
cadc78a
Compare
|
/test e2e |
|
/recheck |
|
/test-e2e |
jianjuns
approved these changes
Nov 15, 2019
This patch implements the rule reconciler that caches the last realized state of each rule and invokes corresponding Openflow interfaces to reconcile the desired rule. Besides, to generate uint32 Openflow ID, it implements an ID allocator.
tnqn
force-pushed
the
networkpolicy-reconciler
branch
from
cadc78a
to
dcc13b9
Compare
|
Thanks for your PR. The following commands are available:
|
|
/test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the rule reconciler that caches the last realized state of each rule and invokes corresponding Openflow interfaces to reconcile the desired rule.
Besides, to generate uint32 Openflow ID, it implements an ID allocator.