Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Antrea traceflow CRD #660

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Implemented Antrea traceflow CRD #660

merged 1 commit into from
Jun 18, 2020

Conversation

lzhecheng
Copy link
Contributor

No description provided.

@lzhecheng lzhecheng requested review from tnqn and gran-vmv April 28, 2020 03:26
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@lzhecheng lzhecheng force-pushed the tf-crd branch 2 times, most recently from b07ff9d to 3a7a417 Compare April 28, 2020 03:48
@lzhecheng lzhecheng changed the title Implemented Antrea traceflow CRD. Implemented Antrea traceflow CRD Apr 28, 2020
@lzhecheng
Copy link
Contributor Author

/test-e2e

@lzhecheng
Copy link
Contributor Author

/test-all

@lzhecheng
Copy link
Contributor Author

/test-networkpolicy

1 similar comment
@lzhecheng
Copy link
Contributor Author

/test-networkpolicy

@jianjuns
Copy link
Contributor

jianjuns commented May 1, 2020

Do we need to generate CRD controller code? Should we switch to kubebuilder? @tnqn

@lzhecheng
Copy link
Contributor Author

/test-e2e

tnqn
tnqn reviewed May 7, 2020
View reviewed changes
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
@lzhecheng lzhecheng force-pushed the tf-crd branch 3 times, most recently from cd3bdbf to 18f3df9 Compare May 12, 2020 07:12
@gran-vmv gran-vmv mentioned this pull request May 22, 2020
Merged
jianjuns
jianjuns reviewed May 27, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.

pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1/types.go Outdated Show resolved Hide resolved
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@ZhangYW18
Copy link
Contributor

ZhangYW18 commented Jun 1, 2020 •
edited
Loading

Hi Zhecheng, me and other colleagues discussed traceflow graph in a meeting before, and noticed that it may be a liitle complicated to make up the texts in the traceflow graph nodes in all cases when drawing graph as we do not know the exact requirements for them. Could we add a field 'text', which means the needed text in nodes apart from the components and the actions, in the traceflow observations?

@lzhecheng lzhecheng force-pushed the tf-crd branch 2 times, most recently from 11a6b0d to 245c155 Compare June 5, 2020 02:06
@lzhecheng
Copy link
Contributor Author

Hi Zhecheng, me and other colleagues discussed traceflow graph in a meeting before, and noticed that it may be a liitle complicated to make up the texts in the traceflow graph nodes in all cases when drawing graph as we do not know the exact requirements for them. Could we add a field 'text', which means the needed text in nodes apart from the components and the actions, in the traceflow observations?

Hi, is this "text" only for graph?

@lzhecheng lzhecheng force-pushed the tf-crd branch 4 times, most recently from 4188db3 to 23ff0ab Compare June 16, 2020 08:41
@lzhecheng lzhecheng requested a review from jianjuns June 16, 2020 08:41
gran-vmv
gran-vmv reviewed Jun 16, 2020
View reviewed changes
build/yamls/antrea-eks.yml Outdated Show resolved Hide resolved
build/yamls/antrea-gke.yml Outdated Show resolved Hide resolved
build/yamls/antrea-ipsec.yml Outdated Show resolved Hide resolved
build/yamls/antrea.yml Outdated Show resolved Hide resolved
build/yamls/base/crds.yml Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/register.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/register.go Outdated Show resolved Hide resolved
@ZhangYW18 ZhangYW18 mentioned this pull request Jun 16, 2020
Merged
tnqn
tnqn reviewed Jun 16, 2020
View reviewed changes
hack/update-codegen-dockerized.sh Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/doc.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/traceflow/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/client/clientset/versioned/fake/register.go Outdated Show resolved Hide resolved
@lzhecheng lzhecheng force-pushed the tf-crd branch 3 times, most recently from d818c34 to 2bbfee3 Compare June 17, 2020 03:02
@lzhecheng lzhecheng requested review from tnqn and jianjuns June 17, 2020 03:08
tnqn
tnqn reviewed Jun 17, 2020
View reviewed changes
pkg/apis/ops/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/ops/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/ops/v1alpha1/types.go Outdated Show resolved Hide resolved
@lzhecheng lzhecheng force-pushed the tf-crd branch 2 times, most recently from 18bf7b7 to bac1a97 Compare June 17, 2020 05:41
@lzhecheng @tnqn
Implemented Antrea traceflow CRD.
52d0157 
Co-authored-by: Quan Tian <qtian@vmware.com>
@lzhecheng lzhecheng requested review from gran-vmv and tnqn June 18, 2020 03:21
@lzhecheng
Copy link
Contributor Author

/test-all

tnqn
tnqn approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhecheng lzhecheng merged commit a95df71 into antrea-io:master Jun 18, 2020
@lzhecheng lzhecheng deleted the tf-crd branch June 18, 2020 04:58
GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@lzhecheng @tnqn @GraysonWu
Implemented Antrea traceflow CRD. (antrea-io#660)
9b17693 
Co-authored-by: Quan Tian <qtian@vmware.com>

Co-authored-by: Quan Tian <qtian@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicky-liu vicky-liu vicky-liu left review comments

@antoninbas antoninbas antoninbas left review comments

@tnqn tnqn tnqn approved these changes

@jianjuns jianjuns Awaiting requested review from jianjuns

@gran-vmv gran-vmv Awaiting requested review from gran-vmv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lzhecheng @antrea-bot @jianjuns @ZhangYW18 @tnqn @antoninbas @vicky-liu @gran-vmv @vmwclabot