Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExternalEntity support on agent side. #782

Closed
wants to merge 1 commit into from
Closed

Add ExternalEntity support on agent side. #782

wants to merge 1 commit into from

Conversation

suwang48404
Copy link
Contributor

@suwang48404 suwang48404 commented Jun 2, 2020 •
edited
Loading

This commit moves ToAddresses/FromAddresses in CompletedRule and AddressSetByGroup in ruleCache to use GroupMemberSet instead of GroupMmeberPodSet. Thus both Pods and ExternalEntities are expressed as GroupMember when in these fields.

Pods in appliedTo field continue be expressed by existing GroupMemberPod, and migration to GroupMember shall be done in a subsequent PR.

@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests.
  • /skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

@suwang48404 suwang48404 force-pushed the ar-crd branch 2 times, most recently from 94d98d7 to 4a8212c Compare June 3, 2020 03:09
@suwang48404
Copy link
Contributor Author

/test-all

@suwang48404 suwang48404 force-pushed the ar-crd branch 4 times, most recently from 83372bf to 54892ea Compare June 4, 2020 04:24
Agent supports ExternalEntity.
411a26e 
This commit moves ToAddresses/FromAddresses in CompletedRule and AddressSetByGroup in ruleCache
to use GroupMemberSet instead of GroupMmeberPodSet. Thus both Pods and ExternalEntities are
expressed as GroupMember when in these fields.

Pods in appliedTo field continue be expressed by existing GroupMemberPod, and migration to GroupMember shall
be done in a subsequent PR.
@suwang48404 suwang48404 changed the title WIP: add ExternalEntity support on agent side. Add ExternalEntity support on agent side. Jun 4, 2020
@suwang48404
Copy link
Contributor Author

/test-all

jianjuns
jianjuns reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At high level, LGTM. But I think @tnqn should review.

@antrea-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@Dyanngg Dyanngg mentioned this pull request Aug 7, 2020
Closed
@Dyanngg
Copy link
Contributor

Dyanngg commented Aug 26, 2020

Superseded by #1084

@Dyanngg Dyanngg closed this Aug 26, 2020
@Dyanngg Dyanngg mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns left review comments

@tnqn tnqn Awaiting requested review from tnqn

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suwang48404 @antrea-bot @Dyanngg @jianjuns @vmwclabot