Fix the issue GARP not being sent #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. The following commands are available:
These commands can only be run by members of the vmware-tanzu organization. |
|
/test-all |
antoninbas
previously approved these changes
Jun 4, 2020
test/e2e/basic_test.go
Outdated
| defer teardownTest(t, data) | ||
|
|
||
| podName := "busybox" | ||
| nodeName := masterNodeName() |
There was a problem hiding this comment.
I wanted the test not limited by node number.
Now I see some tests are using workerNodeName(1) without checking node number, changed to workerNodeName(1) too.
test/e2e/basic_test.go
Outdated
| t.Fatalf("Error when waiting for IP for Pod '%s': %v", podName, err) | ||
| } | ||
|
|
||
| cmd := []string{"ovs-ofctl", "dump-flows", "br-int", fmt.Sprintf("table=10,arp,arp_spa=%s", podIP)} |
There was a problem hiding this comment.
is it possible that by that time the GARPS have not been sent yet, since it is an asynchronous operation in the agent?
There was a problem hiding this comment.
Good catch, I was wondering why the test failed on Jenkin CI only and it got only 1 ARP packet. Maybe it's because of this. I added a sleep and let's see if it's stable now.
|
/test-windows-conformance |
On Linux, to flush stale ARP cache of network, antrea-agent is supposed to send gratuitous ARP packets when configuring network for a Pod. However, the routine was broken when refactoring the "advertiseContainerAddr" method for Windows support. The action was executed in a new spawned goroutine within the context of "NetNS.Do", then it was actually executed after NetNS had switched to the target container NS and had switched back to the host NS. This patch fixes it by executing the whole routine in a goroutine, and fixes the ticker leak problem. It also adds an e2e test to verify there are at least 3 ARP packets received by OVS after a Pod is up to avoid this being broken again as not sending GARP may not lead to connectivity test failure stably if there are no IP reuse before ARP cache expiry.
|
/test-all |
antoninbas
pushed a commit
to antoninbas/antrea
that referenced
this pull request
Jun 5, 2020
On Linux, to flush stale ARP cache of network, antrea-agent is supposed to send gratuitous ARP packets when configuring network for a Pod. However, the routine was broken when refactoring the "advertiseContainerAddr" method for Windows support. The action was executed in a new spawned goroutine within the context of "NetNS.Do", then it was actually executed after NetNS had switched to the target container NS and had switched back to the host NS. This patch fixes it by executing the whole routine in a goroutine, and fixes the ticker leak problem. It also adds an e2e test to verify there are at least 3 ARP packets received by OVS after a Pod is up to avoid this being broken again as not sending GARP may not lead to connectivity test failure stably if there are no IP reuse before ARP cache expiry.
antoninbas
pushed a commit
that referenced
this pull request
Jun 5, 2020
On Linux, to flush stale ARP cache of network, antrea-agent is supposed to send gratuitous ARP packets when configuring network for a Pod. However, the routine was broken when refactoring the "advertiseContainerAddr" method for Windows support. The action was executed in a new spawned goroutine within the context of "NetNS.Do", then it was actually executed after NetNS had switched to the target container NS and had switched back to the host NS. This patch fixes it by executing the whole routine in a goroutine, and fixes the ticker leak problem. It also adds an e2e test to verify there are at least 3 ARP packets received by OVS after a Pod is up to avoid this being broken again as not sending GARP may not lead to connectivity test failure stably if there are no IP reuse before ARP cache expiry.
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Sep 22, 2020
On Linux, to flush stale ARP cache of network, antrea-agent is supposed to send gratuitous ARP packets when configuring network for a Pod. However, the routine was broken when refactoring the "advertiseContainerAddr" method for Windows support. The action was executed in a new spawned goroutine within the context of "NetNS.Do", then it was actually executed after NetNS had switched to the target container NS and had switched back to the host NS. This patch fixes it by executing the whole routine in a goroutine, and fixes the ticker leak problem. It also adds an e2e test to verify there are at least 3 ARP packets received by OVS after a Pod is up to avoid this being broken again as not sending GARP may not lead to connectivity test failure stably if there are no IP reuse before ARP cache expiry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, to flush stale ARP cache of network, antrea-agent is supposed
to send gratuitous ARP packets when configuring network for a Pod.
However, the routine was broken when refactoring the
"advertiseContainerAddr" method for Windows support. The action was
executed in a new spawned goroutine within the context of "NetNS.Do",
then it was actually executed after NetNS had switched to the target
container NS and had switched back to the host NS.
This patch fixes it by executing the whole routine in a goroutine, and
fixes the ticker leak problem. It also adds an e2e test to verify there
are at least 3 ARP packets received by OVS after a Pod is up to avoid
this being broken again as not sending GARP may not lead to connectivity
test failure stably if there are no IP reuse before ARP cache expiry.
For #785