Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added traceflow validation in Hybrid mode #944

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Added traceflow validation in Hybrid mode #944

merged 1 commit into from
Jul 15, 2020

Conversation

gran-vmv
Copy link
Contributor

No description provided.

@gran-vmv gran-vmv added this to the Antrea v0.9.0 release milestone Jul 13, 2020
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@gran-vmv gran-vmv force-pushed the tf-hybrid branch 2 times, most recently from 3b7f012 to 6c990b4 Compare July 13, 2020 06:33
@antrea-bot
Copy link
Collaborator

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

  • /test-e2e: to trigger e2e tests.
  • /skip-e2e: to skip e2e tests.
  • /test-conformance: to trigger conformance tests.
  • /skip-conformance: to skip conformance tests.
  • /test-whole-conformance: to trigger all conformance tests on linux.
  • /skip-whole-conformance: to skip all conformance tests on linux.
  • /test-networkpolicy: to trigger networkpolicy tests.
  • /skip-networkpolicy: to skip networkpolicy tests.
  • /test-windows-conformance: to trigger windows conformance tests.
  • /skip-windows-conformance: to skip windows conformance tests.
  • /test-all: to trigger all tests (except whole conformance).
  • /skip-all: to skip all tests (except whole conformance).

These commands can only be run by members of the vmware-tanzu organization.

@gran-vmv gran-vmv force-pushed the tf-hybrid branch 2 times, most recently from 07fe2b3 to 8e5da3d Compare July 13, 2020 09:25
@gran-vmv
Copy link
Contributor Author

/test-conformance
/test-networkpolicy

@gran-vmv
Copy link
Contributor Author

/test-windows-conformance

1 similar comment
@lzhecheng
Copy link
Contributor

/test-windows-conformance

@gran-vmv
Copy link
Contributor Author

/test-conformance

antoninbas
antoninbas reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but in the future please add a commit description that explains the change

@gran-vmv gran-vmv merged commit b63dc54 into antrea-io:master Jul 15, 2020
@gran-vmv
Copy link
Contributor Author

This looks good but in the future please add a commit description that explains the change

OK. I Added commit description when merging.

GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Sep 22, 2020
@gran-vmv @GraysonWu
Added traceflow validation in Hybrid mode (antrea-io#944)
86bef00 
This commit added validation for traceflow in Hybrid mode.
In Hybrid mode, traceflow feature only supports intra-Node and inter-Node with encapsulation.
@gran-vmv gran-vmv deleted the tf-hybrid branch October 12, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas left review comments

@jianjuns jianjuns jianjuns approved these changes

@tnqn tnqn Awaiting requested review from tnqn

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Antrea v0.9.0 release
Development

Successfully merging this pull request may close these issues.
6 participants
@gran-vmv @antrea-bot @lzhecheng @antoninbas @jianjuns @vmwclabot