Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to increase available memory for e2e test #120

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

yuntanghsu
Copy link
Contributor

@yuntanghsu yuntanghsu commented Oct 7, 2022

Recently e2e tests are failed due to the error: "Error: No space left on device".
Adding workaround to increase available memory at the beginning of e2e test.

Previously, we have 31G available memory when using sudo apt-get clean .
Screen Shot 2022-10-06 at 9 42 46 PM

Adding sudo rm -rf /usr/share/dotnet, sudo rm -rf /opt/ghc, sudo rm -rf "/usr/local/share/boost", sudo rm -rf "$AGENT_TOOLSDIRECTORY" will increase the available memory to 41G

Screen Shot 2022-10-06 at 8 49 27 PM

Signed-off-by: Yun-Tang Hsu hsuy@vmware.com

@yuntanghsu yuntanghsu marked this pull request as draft October 7, 2022 01:10
@yuntanghsu yuntanghsu force-pushed the out_of_disk_space branch 3 times, most recently from 532a8ed to 1cde3a6 Compare October 7, 2022 03:47
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu force-pushed the out_of_disk_space branch 2 times, most recently from 3cb020e to 5e3375d Compare October 7, 2022 04:44
@yuntanghsu yuntanghsu changed the title test Add workaround to increase available memory Oct 7, 2022
@yuntanghsu yuntanghsu changed the title Add workaround to increase available memory Add workaround to increase available memory for e2e test Oct 7, 2022
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yuntanghsu yuntanghsu marked this pull request as ready for review October 7, 2022 05:22
Copy link
Contributor

@wsquan171 wsquan171 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yun-Tang for taking a look of this issue. This workaround should suffice for short term, but we probably need to revisit our e2e on GitHub workflow for the next release.

In our test-e2e-kind.sh, we have

FLOW_VISIBILITY_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --ch-size 100Mi --ch-monitor-threshold 0.1"
FLOW_VISIBILITY_WITH_SPARK_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --no-grafana --spark-operator"
FLOW_VISIBILITY_CH_ONLY_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --no-grafana"

which means we only limited CH disk to 100M for the TestFlowVisibility case, but left it with 8GiB of disk claim for TestPolicyRecommendation, TestTheiaClickHouseStatusCommand and TestUpgrade. I assume disk allocation of 8 GiB for these cases contributed to disk exhuastion? Maybe we can also take a deeper look and see if we can also limit CH disk size for these cases. per linked issue, these runners only guarentee 10GiB of free disk space, which we have exceeded way too much (if it's still the case).

@yuntanghsu
Copy link
Contributor Author

yuntanghsu commented Oct 7, 2022

2022/10/07 00:28:24 Num nodes: 3
2022/10/07 00:28:24 Applying Antrea YAML
2022/10/07 00:29:55 Error when creating logs directory 'beforeTeardown.Oct07-00-29-55': mkdir beforeTeardown.Oct07-00-29-55: no space left on device
2022/10/07 00:29:55 Error when deploying Antrea: error when waiting for antrea-controller rollout to complete - rc: 1 - stdout: Waiting for deployment "antrea-controller" rollout to finish: 0 of 1 updated replicas are available... stderr: error: timed out waiting for the condition

The e2e test failed right after applying antrea YAML. So I think clickhouse might not be related to current issue? Not sure if it's a bug on action side? actions/runner-images#709 (similar error)

The other concern is, for the TestTheiaClickHouseStatusCommand e2e test, since it needs to test the insert-rate information, 100M is not enough for this test (not sure if the other two tests need 8GiB storage?)

Signed-off-by: Yun-Tang Hsu <hsuy@vmware.com>
@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

@yanjunz97
Copy link
Contributor

Thanks Yun-Tang for working on this. Regarding the ClickHouse question, I would like to mention that in TestPolicyRecommendation and TestTheiaClickHouseStatusCommand, CH is deployed in RAM instead of in disk. Thus the storage size should not have effect on the disk space. In TestUpgrade, CH is deployed with local PV, but the size allocated does not mean the size it actually uses. The size 8G is just an annotation, and the disk space it uses depends on the testing contents.

Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a workaround. I agree we may need to revisit our e2e test storage consumption in the future to see if we can reduce the space usage.

@yuntanghsu yuntanghsu merged commit 3c86bef into antrea-io:main Oct 7, 2022
@yuntanghsu yuntanghsu deleted the out_of_disk_space branch October 7, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants