-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround to increase available memory for e2e test #120
Conversation
532a8ed
to
1cde3a6
Compare
/theia-test-e2e |
3cb020e
to
5e3375d
Compare
/theia-test-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Yun-Tang for taking a look of this issue. This workaround should suffice for short term, but we probably need to revisit our e2e on GitHub workflow for the next release.
In our test-e2e-kind.sh
, we have
FLOW_VISIBILITY_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --ch-size 100Mi --ch-monitor-threshold 0.1"
FLOW_VISIBILITY_WITH_SPARK_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --no-grafana --spark-operator"
FLOW_VISIBILITY_CH_ONLY_CMD=$(dirname $0)"/../../hack/generate-manifest.sh --no-grafana"
which means we only limited CH disk to 100M for the TestFlowVisibility case, but left it with 8GiB of disk claim for TestPolicyRecommendation, TestTheiaClickHouseStatusCommand and TestUpgrade. I assume disk allocation of 8 GiB for these cases contributed to disk exhuastion? Maybe we can also take a deeper look and see if we can also limit CH disk size for these cases. per linked issue, these runners only guarentee 10GiB of free disk space, which we have exceeded way too much (if it's still the case).
The e2e test failed right after applying antrea YAML. So I think clickhouse might not be related to current issue? Not sure if it's a bug on action side? actions/runner-images#709 (similar error) The other concern is, for the TestTheiaClickHouseStatusCommand e2e test, since it needs to test the insert-rate information, 100M is not enough for this test (not sure if the other two tests need 8GiB storage?) |
5e3375d
to
8c05d30
Compare
/theia-test-e2e |
Thanks Yun-Tang for working on this. Regarding the ClickHouse question, I would like to mention that in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a workaround. I agree we may need to revisit our e2e test storage consumption in the future to see if we can reduce the space usage.
Recently e2e tests are failed due to the error: "Error: No space left on device".
Adding workaround to increase available memory at the beginning of e2e test.
Previously, we have 31G available memory when using
sudo apt-get clean
.Adding
sudo rm -rf /usr/share/dotnet, sudo rm -rf /opt/ghc, sudo rm -rf "/usr/local/share/boost", sudo rm -rf "$AGENT_TOOLSDIRECTORY"
will increase the available memory to 41GSigned-off-by: Yun-Tang Hsu hsuy@vmware.com