Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes code smells #127

Merged
merged 21 commits into from
Sep 30, 2022
Merged

Removes code smells #127

merged 21 commits into from
Sep 30, 2022

Conversation

pruthvi2103
Copy link
Member

Description

Removes code smells reported by sonar

@pruthvi2103
Squashed commit of the following:
5d46ac2 
commit fb57a63
Author: Saurabh Sutar <81956858+saurabhsutar192@users.noreply.github.com>
Date:   Fri Aug 12 14:13:36 2022 +0530

    HOV-16 | Divider component (antstackio#53)

    * divider component v1 created

    * typos fixed

    * mdx changes

    * divider default color changed

    * mdx changes

    * comments resolved

commit 2f5f842
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:10:43 2022 +0530

    Adds git playbook + adds steps for forking in contribution (antstackio#57)

commit fcc1d6a
Author: Pruthvi Shetty <pruthvishetty5656@gmail.com>
Date:   Fri Aug 12 14:09:52 2022 +0530

    move react to peerDep (antstackio#55)
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
1b68153
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
5ffcd92
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
e164baf
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
ca5c1c0
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
7093f35
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
8a96b6d
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
f19003d
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
50ead6c
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
63b3660
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
e741426
@pruthvi2103
Merge remote-tracking branch 'upstream/main'
c9c9eaa
@pruthvi2103
Removes code smells
324f793
@pruthvi2103 pruthvi2103 added the bug Something isn't working label Sep 29, 2022
@pruthvi2103 pruthvi2103 added this to the v0.1.10-alpha milestone Sep 29, 2022
@pruthvi2103 pruthvi2103 self-assigned this Sep 29, 2022
@netlify
Copy link

netlify bot commented Sep 29, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 14b9710
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6336e43f697f980008570193

@saurabhsutar192
Copy link
Contributor

Tooltip and Popover will have duplications...because the tooltip is based on the popover component....but we decided to keep them separate.

@Raalzz
Copy link
Member

Raalzz commented Sep 30, 2022

Tooltip and Popover will have duplications...because the tooltip is based on the popover component....but we decided to keep them separate.

Is there a way, That we can abstract duplicated code and reuse it wherever needed?

@saurabhsutar192
Copy link
Contributor

Tooltip and Popover will have duplications...because the tooltip is based on the popover component....but we decided to keep them separate.

Is there a way, That we can abstract duplicated code and reuse it wherever needed?

Have to look into it and see what I can do..

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@saurabhsutar192
Copy link
Contributor

LGTM!

@saurabhsutar192 saurabhsutar192 merged commit cdefef6 into antstackio:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalzz Raalzz Awaiting requested review from Raalzz

@saurabhsutar192 saurabhsutar192 Awaiting requested review from saurabhsutar192

Assignees

@pruthvi2103 pruthvi2103

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.1.10-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@pruthvi2103 @saurabhsutar192 @Raalzz