Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Banner Component and Alert Component Changes #130

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Adds Banner Component and Alert Component Changes #130

merged 6 commits into from
Oct 13, 2022

Conversation

saurabhsutar192
Copy link
Contributor

Banner Component

Description

A Banner Component Based on Alert Component, hence reworked on Alert component.

Motivation and Context

No Banner Component

How Has This Been Tested?

Local Build Successful and Manually tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 added documentation Improvements or additions to documentation enhancement New feature or request New Component Addition of new Components labels Oct 11, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.10-alpha milestone Oct 11, 2022
@saurabhsutar192 saurabhsutar192 self-assigned this Oct 11, 2022
@netlify
Copy link

netlify bot commented Oct 11, 2022 •
edited
Loading

✅ Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 5cfe855
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6347e219e047330008abbc56
😎 Deploy Preview https://deploy-preview-130--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pruthvi2103
pruthvi2103 requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment

lib/src/components/Banner/index.tsx Show resolved Hide resolved
@pruthvi2103 pruthvi2103 self-requested a review October 13, 2022 10:02
pruthvi2103
pruthvi2103 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 48fa963 into main Oct 13, 2022
@pruthvi2103 pruthvi2103 deleted the banner-component branch October 13, 2022 10:02
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Assignees

@saurabhsutar192 saurabhsutar192

Labels
documentation Improvements or additions to documentation enhancement New feature or request New Component Addition of new Components
Projects
None yet
Milestone
v0.1.10-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@saurabhsutar192 @pruthvi2103