Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOV-81 | Moves rendering from library side to consumer side #154

Merged
merged 10 commits into from
Jan 7, 2023

Conversation

pruthvi2103
Copy link
Member

Description

Earlier the library was being compiled before hand, making it very static. Now we bundle it on consuming making it easier to add more utilities to make the library dynamic (theming and token modification)

Motivation and Context

to make the library more modifiable and dynamic

How Has This Been Tested?

tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 10a44b8
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/63b80b302050c000080a3ac1
😎 Deploy Preview https://deploy-preview-154--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pruthvi2103 pruthvi2103 changed the title Moves rendering from library side to consumer side HOV-86 | Moves rendering from library side to consumer side Jan 6, 2023
@pruthvi2103 pruthvi2103 changed the title HOV-86 | Moves rendering from library side to consumer side HOV-81 | Moves rendering from library side to consumer side Jan 6, 2023
Copy link
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

lib/package.json Outdated Show resolved Hide resolved
lib/src/components/Breadcrumb/BreadCrumb.stories.tsx Outdated Show resolved Hide resolved
lib/src/components/Checkbox/Checkbox.stories.tsx Outdated Show resolved Hide resolved
lib/src/components/Dialog/Dialog.stories.tsx Outdated Show resolved Hide resolved
lib/src/components/Modal/Modal.stories.tsx Outdated Show resolved Hide resolved
pruthvi2103 and others added 8 commits January 6, 2023 17:13
Co-authored-by: Raalzz <30571073+Raalzz@users.noreply.github.com>
Co-authored-by: Raalzz <30571073+Raalzz@users.noreply.github.com>
Co-authored-by: Raalzz <30571073+Raalzz@users.noreply.github.com>
Co-authored-by: Raalzz <30571073+Raalzz@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit 974788f into antstackio:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants