feat: chart update (#1739)

Co-authored-by: xuying.xu <xuying.xu@alibaba-inc.com>
antvis · Feb 23, 2023 · ca29507 · ca29507
1 parent 12b0a52
commit ca29507
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/f2/src/chart/index.tsx b/packages/f2/src/chart/index.tsx
@@ -119,13 +119,13 @@ class Chart<
   }
 
   // props 更新
-  willReceiveProps(nextProps: IProps) {
+  willReceiveProps(nextProps: IProps, context) {
     const { scale, coord, props: lastProps } = this;
     const { style: nextStyle, data: nextData, scale: nextScale } = nextProps;
     const { style: lastStyle, data: lastData, scale: lastScale } = lastProps;
 
     // style 更新
-    if (!isEqual(nextStyle, lastStyle)) {
+    if (!isEqual(nextStyle, lastStyle) || context !== this.context) {
       const style = this.getStyle(nextProps);
       coord.updateLayout(style);
     }

diff --git a/...nents/canvas/__image_snapshots__/canvas-test-tsx-canvas-chart-update-1-snap.png b/...nents/canvas/__image_snapshots__/canvas-test-tsx-canvas-chart-update-1-snap.png
diff --git a/packages/f2/test/components/canvas/canvas.test.tsx b/packages/f2/test/components/canvas/canvas.test.tsx
@@ -55,13 +55,13 @@ describe('Canvas', () => {
     expect(rect.getAttribute('fill')).toBe('red');
   });
 
-  it.skip('chart update', async () => {
+  it('chart update', async () => {
     const chartRef = { current: null };
     const context = createContext('基础条形图');
     const width = 300;
     const height = 300;
     const { type, props } = (
-      <Canvas context={context} pixelRatio={1} animate={false} width={300} height={300}>
+      <Canvas context={context} pixelRatio={1} animate={false} width={width} height={height}>
         <Chart ref={chartRef} data={data} coord={{ transposed: true }}>
           <Interval x="genre" y="sold" color="type" />
         </Chart>