Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 导出renderShape #1362

Merged
merged 2 commits into from
Feb 10, 2022
Merged

feat: 导出renderShape #1362

merged 2 commits into from
Feb 10, 2022

Conversation

ACERY1
Copy link
Member

@ACERY1 ACERY1 commented Feb 10, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@@ -1,6 +1,7 @@
import { jsx } from '../../../jsx';
import { RectProps } from '../types';
import { TextAttrs } from '../../../types';
import { px2hd } from '../../../util'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px2hd 这个方法不要直接import util 里的,用context 里传进来的那个吧

px2hd 未来是打算开放给外部自己配置的,因为社区里会有很多不一样的高清方案,所以这个方法的处理逻辑也会不一样

@zengyue zengyue merged commit bcb9407 into master Feb 10, 2022
@zengyue zengyue deleted the ms/export/renderShape branch February 10, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants