feat: 导出renderShape #1362
Merged
feat: 导出renderShape #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zengyue
reviewed
Feb 10, 2022
| @@ -1,6 +1,7 @@ | |||
| import { jsx } from '../../../jsx'; | |||
| import { RectProps } from '../types'; | |||
| import { TextAttrs } from '../../../types'; | |||
| import { px2hd } from '../../../util' | |||
There was a problem hiding this comment.
px2hd 这个方法不要直接import util 里的，用context 里传进来的那个吧
px2hd 未来是打算开放给外部自己配置的，因为社区里会有很多不一样的高清方案，所以这个方法的处理逻辑也会不一样
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change