Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 事件挂载gesture属性上 & 补充圆角单测 #1525

Merged
merged 6 commits into from
Jun 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/f2/src/components/axis/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface Point {
}

export interface Tick {
value: number;
points: Point[];
text: string;
tickValue: string | number;
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/geometry/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ class Geometry<
['onPressStart', 'onPress', 'onPressEnd', 'onPan', 'onPanStart', 'onPanEnd'].forEach(
(eventName) => {
if (props[eventName]) {
context.root.on(eventName.substr(2).toLowerCase(), (ev) => {
context.gesture.on(eventName.substr(2).toLowerCase(), (ev) => {
ev.geometry = this;
props[eventName](ev);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/geometry/selection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class Selection<
if (!selection) return;
// 默认为 click
const { triggerOn = 'click' } = selection;
context.root.on(triggerOn, (ev) => {
context.gesture.on(triggerOn, (ev) => {
const { points } = ev;
const records = this.getSnapRecords(points[0]);
const { type = 'single', cancelable = true } = selection;
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/guide/withGuide.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default (View) => {
const { canvas } = context;
const { onClick } = props;

context.root.on('click', (ev) => {
context.gesture.on('click', (ev) => {
const { points } = ev;
const shape = this.triggerRef.current;
if (!shape || shape.isDestroyed()) return;
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/legend/withLegend.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export default (View) => {
if (!clickable) return;

// item 点击事件
context.root.on('click', (ev) => {
context.gesture.on('click', (ev) => {
const { points } = ev;

const point = points[0];
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/pieLabel/withPieLabel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export default (View) => {
const { context, props } = this;
const { canvas } = context;
const { triggerOn = DEFAULT_CONFIG.triggerOn } = props;
context.root.on(triggerOn, this._handleEvent);
context.gesture.on(triggerOn, this._handleEvent);
}

render() {
Expand Down
2 changes: 1 addition & 1 deletion packages/f2/src/components/sunburst/withSunburst.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default (View) => {
const { canvas } = context;
this.triggerRef = [];

context.root.on('click', (ev) => {
context.gesture.on('click', (ev) => {
const { points } = ev;
const shape = this.triggerRef.find((ref) => {
return isInBBox(ref.current.getBBox(), points[0]);
Expand Down
8 changes: 4 additions & 4 deletions packages/f2/src/components/tooltip/withTooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ export default (View) => {
const { props, context } = this;
const { triggerOn = 'press', triggerOff = 'pressend' } = props;
// 解绑事件
context.root.off(triggerOn, this._triggerOn);
context.root.off(triggerOff, this._triggerOff);
context.gesture.off(triggerOn, this._triggerOn);
context.gesture.off(triggerOff, this._triggerOff);
}
_initShow() {
const { props } = this;
Expand Down Expand Up @@ -129,12 +129,12 @@ export default (View) => {
_initEvent() {
const { context, props } = this;
const { triggerOn = 'press', triggerOff = 'pressend', alwaysShow = false } = props;
context.root.on(triggerOn, (ev) => {
context.gesture.on(triggerOn, (ev) => {
const { points } = ev;
this.show(points[0], ev);
});

context.root.on(triggerOff, (_ev) => {
context.gesture.on(triggerOff, (_ev) => {
if (!alwaysShow) {
this.hide();
}
Expand Down
25 changes: 12 additions & 13 deletions packages/f2/src/components/zoom/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -276,19 +276,18 @@ class Zoom<P extends ZoomProps = ZoomProps, S extends ZoomState = ZoomState> ext

_bindEvents() {
const { props, context } = this;
const { canvas } = context;
const { pan, pinch } = props;
// 统一绑定事件
if (pan !== false) {
context.root?.on('panstart', this.onStart);
context.root?.on('pan', this.onPan);
context.root?.on('panend', this.onEnd);
context.gesture?.on('panstart', this.onStart);
context.gesture?.on('pan', this.onPan);
context.gesture?.on('panend', this.onEnd);
}

if (pinch !== false) {
context.root?.on('pinchstart', this.onStart);
context.root?.on('pinch', this.onPinch);
context.root?.on('pinchend', this.onEnd);
context.gesture?.on('pinchstart', this.onStart);
context.gesture?.on('pinch', this.onPinch);
context.gesture?.on('pinchend', this.onEnd);
}
}

Expand All @@ -298,14 +297,14 @@ class Zoom<P extends ZoomProps = ZoomProps, S extends ZoomState = ZoomState> ext
const { pan, pinch } = props;
// 统一解绑事件
if (pan !== false) {
context.root?.off('panstart', this.onStart);
context.root?.off('pan', this.onPan);
context.root?.off('panend', this.onEnd);
context.gesture?.off('panstart', this.onStart);
context.gesture?.off('pan', this.onPan);
context.gesture?.off('panend', this.onEnd);
}
if (pinch !== false) {
context.root?.off('pinchstart', this.onStart);
context.root?.off('pinch', this.onPinch);
context.root?.off('pinchend', this.onEnd);
context.gesture?.off('pinchstart', this.onStart);
context.gesture?.off('pinch', this.onPinch);
context.gesture?.off('pinchend', this.onEnd);
}
}
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
41 changes: 39 additions & 2 deletions packages/f2/test/components/interval/example/pie.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { jsx } from '../../../../src';
import { Polar, Rect } from '../../../../src/coord';
import { isArray } from '@antv/util';
import { Canvas, Chart, Component } from '../../../../src';
import { Hammer } from '@antv/f-engine';
import { Gesture } from '@antv/f-engine';
import { Interval } from '../../../../src/components';
import { createContext, delay, gestureSimulator } from '../../../util';

Expand Down Expand Up @@ -31,7 +31,7 @@ class Test extends Component {
_initEvent() {
const { context } = this;
const { canvas } = context;
const hammer = new Hammer(canvas);
const hammer = new Gesture(canvas);
hammer.on('click', this._handleEvent);
}

Expand Down Expand Up @@ -126,6 +126,43 @@ describe('饼图', () => {
expect(context).toMatchImageSnapshot();
});

it('圆角圆环图', async () => {
const context = createContext('圆角圆环图');
const chartRef = { current: null };
const { type, props } = (
<Canvas context={context} pixelRatio={1}>
<Chart
ref={chartRef}
data={data}
coord={{
type: Polar,
transposed: true,
innerRadius: 0.5,
}}
>
<Interval
x="a"
y="percent"
adjust="stack"
color={{
field: 'name',
range: ['#1890FF', '#13C2C2', '#2FC25B', '#FACC14', '#F04864', '#8543E0'],
}}
style={{
radius: [10, 7, 4, 2],
}}
/>
</Chart>
</Canvas>
);

const canvas = new Canvas(props);
canvas.render();

await delay(1000);
expect(context).toMatchImageSnapshot();
});

it('饼图-交互式label', async () => {
const context = createContext('饼图-交互式label');
const chartRef = { current: null };
Expand Down