Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insertBefore 插入的位置不对 #1568

Closed
zengyue opened this issue Oct 31, 2023 · 1 comment
Closed

insertBefore 插入的位置不对 #1568

zengyue opened this issue Oct 31, 2023 · 1 comment
Assignees
@xiaoiver
Labels
bug

Comments

@zengyue
Copy link
Member

zengyue commented Oct 31, 2023

测试代码：https://codesandbox.io/s/sad-gagarin-ql22t9?file=/src/index.js:1069-1081

预期应该是 circle, ellipse, rect
但是实际输出确实下面这个
image
@xiaoiver xiaoiver self-assigned this Nov 1, 2023
@xiaoiver xiaoiver added the bug label Nov 1, 2023
xiaoiver added a commit that referenced this issue Nov 1, 2023
@xiaoiver
fix: insertBefore should use correct position #1568
f1dd90e
xiaoiver added a commit that referenced this issue Nov 1, 2023
@xiaoiver
Fix 1568 (#1569)
51b42d0 
* fix: insertBefore should use correct position #1568

* chore: commit changeset
xiaoiver added a commit that referenced this issue Nov 1, 2023
@xiaoiver @github-actions
Release (#1571)
3a65536 
* Fix 1568 (#1569)

* fix: insertBefore should use correct position #1568

* chore: commit changeset

* chore(release): bump version (#1570)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver
Copy link
Contributor

xiaoiver commented Nov 1, 2023

https://github.com/antvis/G/releases/tag/%40antv%2Fg%405.18.19

@xiaoiver xiaoiver closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoiver xiaoiver

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zengyue @xiaoiver