fix: remove defXY and cx/cy should not affect transform #1624 #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| /** | ||
| * <pattern> | ||
| * support the following image source: | ||
| * * HTMLImageElement (<img>) |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
| export async function pattern({ canvas }) { | ||
| await canvas.ready; | ||
|
|
||
| // <img> URL |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
| canvas.appendChild(rect4); | ||
|
|
||
| { | ||
| // HTMLImageElement(<img>) |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
xiaoiver
added a commit
that referenced
this pull request
Mar 21, 2024
* fix: remove defXY and cx/cy should not affect transform #1624 (#1627) * fix: remove defXY and cx/cy should not affect transform #1624 * fix: patterns * fix: remove anchor * fix: annotation plugin * chore: commit changeset * fix: x/y in rect can be omitted * chore: commit changeset * chore: version * chore: version * chore: bump version * fix: insert event will trigger by default * chore: commit changeset * fix: lazy update geometry * fix: lazy calculate geometry * chore: bump version * fix: refactor parse transform * fix: transform origin * chore: bump * chore: stash * chore: bump test version * chore: fix testcases * chore: update snapshots * chore: commit changeset * chore: commit changeset (#1646) * chore(release): bump version (#1645) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#1624
💡 Background and solution
目前以下属性均会影响 transform，不光会增加初始化阶段的时间影响性能，也会让 transformOrigin 这样的属性变得晦涩。
GUI / G2 中由该问题引发了不少问题：
因此在 group & customElement 去除 x/y 属性，同时去除 anchor 属性。
值得一提的是在 SVG 规范中 也是没有 x/y 属性的：https://developer.mozilla.org/en-US/docs/Web/SVG/Element/g
📝 Changelog
☑️ Self Check before Merge