Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(g-canvas): bbox calculation for path is incorrect when angle is 0 and π #256

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

dengfuping
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix that bbox calculation for path is incorrect when angle is 0 and π. #254.
🇨🇳 Chinese 🐞 [g-canvas] 修复当 path 的夹角为 0 和 π 时,包围盒计算错误的问题。#254.

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 4, 2019

Deploy preview for antv-g ready!

Built with commit d405eb7

https://deploy-preview-256--antv-g.netlify.com

@dengfuping dengfuping changed the title fix(g-canvas): Fix that bbox calculation for path is incorrect when angle is 0 and π fix(g-canvas): bbox calculation for path is incorrect when angle is 0 and π Nov 4, 2019
@dengfuping dengfuping merged commit db572fa into 4.x Nov 4, 2019
@dengfuping dengfuping deleted the fix-issue-254 branch November 4, 2019 08:39
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
fix(g-canvas): bbox calculation for path is incorrect when angle is 0 and π
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant