Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(g-canvas): should render correctly when start point and end point are same for arc #297

Merged
merged 1 commit into from
Dec 11, 2019
Merged

fix(g-canvas): should render correctly when start point and end point are same for arc #297

merged 1 commit into from
Dec 11, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Dec 9, 2019 •
edited
Loading

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • The case of start point and end pointer should be considered.

📝 Changelog

Language Changelog
🇺🇸 English 🐞 [g-canvas] Fix incorrect rendering for arc when start point and end point are same. #287 #292
🇨🇳 Chinese 🐞 [g-canvas] 修复起点和终点相同时，弧形绘制不正确的问题。#287 #292

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@auto-add-label auto-add-label bot added the bug label Dec 9, 2019
tests-checker[bot]
tests-checker bot suggested changes Dec 9, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 9, 2019 •
edited
Loading

Deploy preview for antv-g ready!

Built with commit 8342ad5

https://deploy-preview-297--antv-g.netlify.com

@dengfuping dengfuping mentioned this pull request Dec 9, 2019
Closed
@dengfuping dengfuping merged commit 2eab551 into master Dec 11, 2019
@dengfuping dengfuping deleted the fix-issue-287 branch December 11, 2019 10:43
@dengfuping
Copy link
Member Author

openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
Merge pull request antvis#297 from antvis/fix-issue-287
8a9cf47 
fix(g-canvas): should render correctly when start point and end point are same for arc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@dxq613 dxq613 Awaiting requested review from dxq613

Assignees
No one assigned
Labels
bug PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[4.0] 包围盒计算错误，导致 shape 绘制不出来
1 participant
@dengfuping