Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(g-canvas & g-svg): add getTotalLength and getPoint method for Polyline #312

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Dec 12, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 对于 SVG 版本,polyline 元素原生的 getTotalLength()getPointAtLength(ratio) 方法目前的浏览器兼容性不是特别好,先采用数学计算的方式实现。

image

📝 Changelog

Language Changelog
🇺🇸 English 🌟 [g-canvas & g-svg] Add getTotalLength() and getPoint(ratio) method for Polyline. #295
🇨🇳 Chinese 🌟 [g-canvas & g-svg] Polyline 新增 getTotalLength()getPoint(ratio) 成员方法。#295

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 12, 2019

Deploy preview for antv-g ready!

Built with commit 746271b

https://deploy-preview-312--antv-g.netlify.com

@dengfuping dengfuping merged commit 6ec633c into master Dec 12, 2019
@dengfuping dengfuping deleted the feat-polyline branch December 12, 2019 10:07
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
feat(g-canvas & g-svg): add getTotalLength and getPoint method for Polyline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant