-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tooltip markerType #6292
Conversation
Pull Request Test Coverage Report for Build 9525298246Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9529017088Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在案例中增加一个案例?可以把之前 crosshair 那个 PR 的案例也加上,给大家秀一秀 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在案例中增加一个案例?可以把之前 crosshair 那个 PR 的案例也加上,给大家秀一秀 🤣
好的,我这加一下 |
@Runtus 你案例截图发给我,我把它们上传之后,把链接给你。 |
|
Pull Request Test Coverage Report for Build 9541988696Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
@Runtus 我是指在 site/examples/component/tooltip 这里增加两个例子 🤣。不过这个 PR 我先合并了,你可以专门来一个 PR 添加例子。 |
Pull Request Test Coverage Report for Build 9544299865Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
不好意思,没get到点,我晚上改一下,今天有点忙哈哈哈所以思维有点乱🤣 |
@Runtus 没事没事,可能我没有说清楚,不着急哈😆 |
Checklist
npm test
passesDescription of change
markerType: "hollow"
。closed: #5999
closed: #6074