Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): update show sparkline condition and fix test #6317

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

deletenothing
Copy link
Contributor

@deletenothing deletenothing commented Jun 24, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

fix(slider): update show sparkline condition and fix test
fixes #6137 ,以及多个mark时配置非第一个mark不起效的问题

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9643212837

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 86.377%

Totals Coverage Status
Change from base Build 9642906607: -0.001%
Covered Lines: 10401
Relevant Lines: 11661

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearmini
Copy link
Member

@deletenothing

这个 #6137 里面提到的下面问题还有吗?

第二,我在review代码的时候发现了另一处数据处理bug。如果slider配置在面积图的第二个图上,sparkline没有起效。也可一并修复。
第三,想问一下,目前的sparkline数据通道只考虑了'y'和 'series'。对于其他数据通道我不怎么熟悉,想问问有无其他情况下需要处理和考虑的。
第四,目前sparkline的颜色和图例以及tooltip之类的不一致。如果我想优化这个,可以给一些提示吗

@pearmini pearmini merged commit 1589404 into antvis:v5 Jun 25, 2024
2 checks passed
@deletenothing
Copy link
Contributor Author

第二,我在review代码的时候发现了另一处数据处理bug。如果slider配置在面积图的第二个图上,sparkline没有起效。也可一并修复。

这个修了。但是在跑测试的时候注意到,对于数据有缺失的图,sparkline没法显示,这个还未解决;以及sparkline的颜色和图例以及tooltip之类的不一致,这个也尚未解决。@pearmini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置slider的formatter后,sparkline不再显示
3 participants