Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(Histogram): Auto calculate range tickInterval by binWidth and binNumber #3486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve(Histogram): Auto calculate range tickInterval by binWidth and binNumber #3486

wants to merge 3 commits into from

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Mar 7, 2023 •
edited
Loading

PR includes

  • add / modify test cases
  • documents, demos

Screenshot

  • In most scenarios, binWidth is always same as tickInterval. So auto calculating tickInterval is more convenient.
  • Grafana demo:

image

  • when binWidth is 2:
Before After
image image

@hustcc
Copy link
Member

hustcc commented May 22, 2023

单侧似乎报错了。

@dengfuping
Copy link
Member Author

单侧似乎报错了。

单测一直没有跑完，看了下其他 PR 也是这样，是否是项目配置的问题？

image

@hustcc
Copy link
Member

hustcc commented Jun 26, 2023

rebase 一下 master 应该可以运行了。

@18211365467
Copy link

coordinate不能更新的问题能优化一下么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dengfuping @hustcc @18211365467