Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): spider label line drawing error #84

Merged
merged 2 commits into from
Sep 29, 2019
Merged

Conversation

paleface001
Copy link
Contributor

No description provided.

@auto-add-label auto-add-label bot added the Bug Something isn't working label Sep 29, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@paleface001
Copy link
Contributor Author

@zqlu 改成使用方法了

@@ -70,7 +70,7 @@ export default class SpiderLabel {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotRadius在PolarCoord中被设置成了private,最好是用getRadius()方法?center也是一样,startAngle可能还需要在PolarCoord中添加方法

@lessmost lessmost merged commit 1cfbc9d into master Sep 29, 2019
@lessmost lessmost deleted the fix_spiderLabel branch September 29, 2019 06:52
@paleface001 paleface001 mentioned this pull request Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants