Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。 #128

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

ParryQiu
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

修复如果用户传递的是基于 mapboxgl 封装后的对象,一些参数的判断问题。

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 17, 2019

Deploy preview for trusting-saha-7bb4e5 ready!

Built with commit ba18020

https://deploy-preview-128--trusting-saha-7bb4e5.netlify.com

@ParryQiu ParryQiu changed the title 针对传递 mapInstance 时,一些参数判断问题。 Fixed the problem of checking mapInstance related parameters. Dec 17, 2019
@lzxue lzxue changed the title Fixed the problem of checking mapInstance related parameters. fix (mapnox) : 针对传递 mapInstance 时,一些参数判断问题。 Dec 17, 2019
@lzxue lzxue changed the title fix (mapnox) : 针对传递 mapInstance 时,一些参数判断问题。 fix (mapnox): 针对传递 mapInstance 时,一些参数判断问题。 Dec 17, 2019
@lzxue lzxue changed the title fix (mapnox): 针对传递 mapInstance 时,一些参数判断问题。 fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。 Dec 17, 2019
@auto-add-label auto-add-label bot added the bug 这个是一个 bug label Dec 17, 2019
@lzxue lzxue merged commit a1c5bf9 into antvis:layer Dec 18, 2019
lzxue added a commit that referenced this pull request Mar 5, 2020
fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。
lzxue added a commit that referenced this pull request Mar 5, 2020
fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。
lzxue added a commit that referenced this pull request Mar 5, 2020
fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。
lzxue added a commit that referenced this pull request Mar 6, 2020
fix(mapbox): 针对传递 mapInstance 时,一些参数判断问题。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 这个是一个 bug PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants