Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react #219

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Fix react #219

merged 2 commits into from
Feb 21, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Feb 20, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

tests-checker[bot]
tests-checker bot suggested changes Feb 20, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lzxue lzxue merged commit bb418d4 into master Feb 21, 2020
@lzxue lzxue deleted the fix_react branch February 21, 2020 01:15
@pr-triage pr-triage bot added the PR: merged label Feb 21, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #219 from antvis/fix_react
e0254eb 
Fix react
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #219 from antvis/fix_react
8252f49 
Fix react
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #219 from antvis/fix_react
3100b1d 
Fix react
lzxue added a commit that referenced this pull request Mar 6, 2020
@lzxue
Merge pull request #219 from antvis/fix_react
aec7f9d 
Fix react
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lzxue