Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 标签样式支持描边宽度与描边宽颜色 #68

Merged
merged 3 commits into from
Nov 3, 2023
Merged

fix: 标签样式支持描边宽度与描边宽颜色 #68

merged 3 commits into from
Nov 3, 2023

Conversation

simplexiao
Copy link
Contributor

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@github-actions github-actions bot added the bugfix label Nov 3, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

🎊 PR Preview 685ce13 has been successfully built and deployed to https://antvis-L7VP-preview-pr-68.surge.sh

🕐 Build time: 0.018s

🤖 By surge-preview

lvisei
lvisei previously approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@lvisei lvisei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

客流图层看下有没有标签，中国行政图层也要加一下这两个属性

packages/li-p2/src/LayerAttribute/common-schema/label-collapse.ts Outdated Show resolved Hide resolved
@lvisei lvisei marked this pull request as draft November 3, 2023 03:47
@lvisei lvisei marked this pull request as ready for review November 3, 2023 03:47
@lvisei lvisei self-requested a review November 3, 2023 03:48
@lvisei lvisei dismissed their stale review November 3, 2023 03:48

客流图层看下有没有标签，中国行政图层也要加一下这两个属性

@lvisei lvisei merged commit 8a47d9e into master Nov 3, 2023
3 checks passed
@lvisei lvisei deleted the style-label-stroke branch November 3, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvisei lvisei lvisei approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simplexiao @lvisei