Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attr 实例化时不判断数据相关的特征 #1243

Merged
merged 2 commits into from
Nov 10, 2021
Merged

fix: attr 实例化时不判断数据相关的特征 #1243

merged 2 commits into from
Nov 10, 2021

Conversation

ACERY1
Copy link
Member

@ACERY1 ACERY1 commented Nov 9, 2021

  • 创建 attr 的时候不应该去判断数据的特征来创建不同类型的attr。
  • 兜底用 Category Attr，因为 x、y 已经强制设置为 Linear 了
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2021

This pull request introduces 1 alert when merging d77bf52 into b0f1b23 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request introduces 1 alert when merging a3fbbe2 into 1911553 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@zengyue zengyue merged commit d94db4f into v4.0.x Nov 10, 2021
@zengyue zengyue deleted the fix/attr branch November 10, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ACERY1 @zengyue