New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(band): using normalizedFlex to compute bandWidth and step #184

Merged

pearmini merged 1 commit into master from fix/band

Apr 27, 2022

Member

pearmini commented Apr 27, 2022

Below band scale will compute wrong bandWidth and step because the flex options is not normalized. This PR fix this problem.

const band = new Band({
  flex: [100, 200, 300]
});


          fix(band): using normalizedFlex to compute bandWidth and step

ade0745

pearmini requested a review from hustcc

April 27, 2022 08:22

hustcc approved these changes

View reviewed changes

pearmini merged commit c3140bc into master

pearmini deleted the fix/band branch

April 27, 2022 09:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet