feat: add a util to calculate max and min number & omit #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Feb 9, 2021
packages/util/src/max.ts
Outdated
| * // Math.max(...data) will encounter "Maximum call stack size exceeded" error | ||
| */ | ||
| export default (arr: number[]): number | undefined => { | ||
| return maxBy(arr, (d) => d); |
There was a problem hiding this comment.
? max(...arr), 没有 max 方法，还是说不直接使用 maxBy 了，自己写一个
|
直接升级版本，然后合并之后打包。 |
visiky
changed the title
visiky
changed the title
hustcc
reviewed
Feb 10, 2021
| return r; | ||
| }, | ||
| {} | ||
| ); |
hustcc
approved these changes
Feb 10, 2021
|
已经发包。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加了
max,min和omitutil, 修复了get-range遇到极大数量出错的问题