Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:add x6 sites base on gh-pages #167

Merged
merged 2 commits into from
Jun 12, 2020
Merged

feat:add x6 sites base on gh-pages #167

merged 2 commits into from
Jun 12, 2020

Conversation

NewByVector
Copy link
Contributor

Description

add x6 sites base on gh-pages

Motivation and Context

Create official website

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pr-triage pr-triage bot added the PR: unreviewed PR does not have any reviews. label Jun 12, 2020
tests-checker[bot]
tests-checker bot suggested changes Jun 12, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jun 12, 2020
accesslint[bot]
accesslint bot suggested changes Jun 12, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

packages/x6-sites/docs/manual/introduce.en.md Outdated

## 使用

![](https://gw.alipayobjects.com/mdn/rms_6ae20b/afts/img/A*Hz29QLOXPRYAAAAAAAAAAABkARQnAQ)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

packages/x6-sites/docs/manual/introduce.zh.md Outdated

## 使用

![](https://gw.alipayobjects.com/mdn/rms_6ae20b/afts/img/A*Hz29QLOXPRYAAAAAAAAAAABkARQnAQ)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 12, 2020

This pull request introduces 1 alert when merging 740f8b4 into 2a214b9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@NewByVector NewByVector changed the title feat(site):add x6 sites base on gh-pages feat:add x6 sites base on gh-pages Jun 12, 2020
@NewByVector
Copy link
Contributor Author

feat:add x6 sites base on gh-pages

bubkoo
bubkoo requested changes Jun 12, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Jun 12, 2020
accesslint[bot]
accesslint bot suggested changes Jun 12, 2020
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

packages/x6-site/docs/manual/introduce.en.md

## 使用

![](https://gw.alipayobjects.com/mdn/rms_6ae20b/afts/img/A*Hz29QLOXPRYAAAAAAAAAAABkARQnAQ)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

packages/x6-site/docs/manual/introduce.zh.md

## 使用

![](https://gw.alipayobjects.com/mdn/rms_6ae20b/afts/img/A*Hz29QLOXPRYAAAAAAAAAAABkARQnAQ)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@pr-triage pr-triage bot added PR: reviewed-changes-requested PR has reviewed and got Change request event. and removed PR: unreviewed PR does not have any reviews. labels Jun 12, 2020
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 12, 2020

This pull request introduces 1 alert when merging 6931761 into 2f42b4f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@bubkoo bubkoo merged commit 534d0d2 into antvis:master Jun 12, 2020
@pr-triage pr-triage bot added PR: merged PR has merged. and removed PR: reviewed-changes-requested PR has reviewed and got Change request event. labels Jun 12, 2020
@afc163
Copy link
Contributor

afc163 commented Jun 16, 2020

image

邮箱没绑定对。

@x6-bot
Copy link
Contributor

x6-bot bot commented Mar 7, 2021

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bubkoo bubkoo bubkoo requested changes

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@accesslint accesslint[bot] accesslint[bot] requested changes

Assignees
No one assigned
Labels
PR: merged PR has merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewByVector @afc163 @bubkoo