Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hypertheme #74

Merged
merged 8 commits into from
Mar 3, 2022
Merged

add hypertheme #74

merged 8 commits into from
Mar 3, 2022

Conversation

panbenson
Copy link
Contributor

@panbenson panbenson commented Feb 28, 2022

@vercel
Copy link

vercel bot commented Feb 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anubra266/choc-ui/6XcAx297JMh2VJftQGz2vgCTmjtj
✅ Preview: https://choc-ui-git-fork-panbenson-add-hypertheme-anubra266.vercel.app

theme/index.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@anubra266 anubra266 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @panbenson thanks for picking this up.
Your changes are unable to deploy, because there's a type error.
CleanShot 2022-03-01 at 00 21 57@2x

I'm guessing, we're setting brand to accepts either a string, or a JSON object. We have to specify the type for brand, explicitly.
useState<Type>()

@panbenson
Copy link
Contributor Author

thanks @anubra266, it should be a JSON type which I made updates to reflect. I'm unable to view the vercel logs, is there some way to repro the errors locally?

@anubra266
Copy link
Owner

@panbenson you can pull the latest changes,and use yarn lint

@panbenson
Copy link
Contributor Author

@anubra266 is whats failing on the vercel deployment? yarn lint is passing locally for me

Screen Shot 2022-03-01 at 8 15 29 PM

@anubra266
Copy link
Owner

@anubra266 is whats failing on the vercel deployment? yarn lint is passing locally for me

Screen Shot 2022-03-01 at 8 15 29 PM

@panbenson what of when you run yarn build?

@anubra266
Copy link
Owner

@anubra266 is whats failing on the vercel deployment? yarn lint is passing locally for me

Screen Shot 2022-03-01 at 8 15 29 PM

Yeah it's on the vercel deployment

@panbenson
Copy link
Contributor Author

@anubra266 are you able to add me to the vercel team/copy me the logs? not able to access them from the "Details" link

@anubra266
Copy link
Owner

@panbenson, the picture here is the error showing up in deployment: #74 (review)

@panbenson
Copy link
Contributor Author

@anubra266 changes are good to go! please have a look at the deployment when you have a chance

@panbenson panbenson requested a review from anubra266 March 3, 2022 02:30
@anubra266 anubra266 merged commit 4b45991 into anubra266:main Mar 3, 2022
@anubra266
Copy link
Owner

@all-contributors please add @panbenson for code

@allcontributors
Copy link
Contributor

@anubra266

I've put up a pull request to add @panbenson! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hypertheme
2 participants