-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hypertheme #74
add hypertheme #74
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/anubra266/choc-ui/6XcAx297JMh2VJftQGz2vgCTmjtj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @panbenson thanks for picking this up.
Your changes are unable to deploy, because there's a type error.
I'm guessing, we're setting brand to accepts either a string, or a JSON object. We have to specify the type for brand, explicitly.
useState<Type>()
thanks @anubra266, it should be a JSON type which I made updates to reflect. I'm unable to view the vercel logs, is there some way to repro the errors locally? |
@panbenson you can pull the latest changes,and use |
@anubra266 is whats failing on the vercel deployment? |
@panbenson what of when you run yarn build? |
Yeah it's on the vercel deployment |
@anubra266 are you able to add me to the vercel team/copy me the logs? not able to access them from the "Details" link |
@panbenson, the picture here is the error showing up in deployment: #74 (review) |
@anubra266 changes are good to go! please have a look at the deployment when you have a chance |
@all-contributors please add @panbenson for code |
I've put up a pull request to add @panbenson! 🎉 |
uses hypertheme for theme customization
Fixes #62
demo:
https://user-images.githubusercontent.com/15132025/155914561-9f54ac67-3402-43ad-9f80-c10711f52066.mov