Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kagreenwell issue 270 patch #384

Merged
merged 14 commits into from
Oct 18, 2019
Merged

Kagreenwell issue 270 patch #384

merged 14 commits into from
Oct 18, 2019

Conversation

kagreenwell
Copy link
Contributor

@kagreenwell kagreenwell commented Oct 7, 2019

Removed specific values to generalize annex. Also replaced html with git style markdown.
Issue: #270

moved FuncTest to 8.3.1. FuncTest is OpenStack specific, not generic. If we want to populate the Generic Test Cases section, we will need to be more generic. This is still a WIP
Remove specific value references and cleanup wording.
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
@rabi-abdel
Copy link
Collaborator

with the new structure, Ch08-annex will move more towards CNTT RC NFVI, CNTT RC VNF, and CNTT RC Dev.

We should not have test cases targeting specific vendor solution or very hw specific.

@rabi-abdel
Copy link
Collaborator

I suggest @kagreenwell to do as much cleanup as possible in here, get it approved and merged. Then we will have another issue to move this content to the relevant WS (as per after re-structuring).

Copy link
Contributor Author

@kagreenwell kagreenwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rabi-
We are aligned. I had the same conversation with Mike. This cleanup is being done with the expectation that the results of it will be incorporated into the OpenStack specific RI documents when the rewrite is done.

doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
@rabi-abdel
Copy link
Collaborator

@kagreenwell let me know when you are happy with the PR and it is ready to be merged. I will place it in 48 hour cool off period before merge.

@kagreenwell
Copy link
Contributor Author

@kagreenwell let me know when you are happy with the PR and it is ready to be merged. I will place it in 48 hour cool off period before merge.

All conversations have been resolved and requested updates are in place. I am good with merging this.

doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Show resolved Hide resolved
doc/ref_model/chapters/chapter08-annex.md Outdated Show resolved Hide resolved
@rabi-abdel
Copy link
Collaborator

Approve

@rabi-abdel
Copy link
Collaborator

@mf4716 please approve so i can merge.

@rabiabdel
Copy link
Collaborator

The new process kicked in: so we now need 4 approvals for this to be merged! @yangyanyj since you are the new lead for RM Com, can you please approve this PR and propose 1 operator to approve it and 2 vendors to approve it? They need to be from the contributors list and active. use your judgment of who they should be.

@cntt-n
Copy link
Contributor

cntt-n commented Oct 18, 2019

This has been created beore the restructure. so i will use admin priviliges to merge it. more issues can be created later to fix and will follow the process.

@cntt-n cntt-n merged commit 4e8a61b into master Oct 18, 2019
@cntt-n cntt-n deleted the kagreenwell-issue-270-patch branch October 18, 2019 12:33
@rabi-abdel rabi-abdel added the Archive Archive Item label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archive Archive Item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants