Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React] [Fix] Changing theme should not re-render SVG waves #6

Closed
anup-a opened this issue Oct 16, 2020 · 2 comments · Fixed by #7
Closed

[React] [Fix] Changing theme should not re-render SVG waves #6

anup-a opened this issue Oct 16, 2020 · 2 comments · Fixed by #7
Assignees
@ansh-saini
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@anup-a
Copy link
Owner

anup-a commented Oct 16, 2020

  • Changing theme to dark-light mode rerenders the wave
  • This is bound to happen since wave re-renders whenever the state changes.
  • Possible fix could be to use useEffect hook.
@anup-a anup-a added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 16, 2020
@anup-a anup-a changed the title [React] [Fix] Changing theme should not renderes SVG waves [React] [Fix] Changing theme should not re-render SVG waves Oct 16, 2020
@ansh-saini
Copy link
Contributor

Can I work on this?

@anup-a
Copy link
Owner Author

anup-a commented Oct 16, 2020

Sure go ahead.
Feel free to ask any questions.

@ansh-saini ansh-saini mentioned this issue Oct 16, 2020
Merged
@anup-a anup-a closed this as completed in #7 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansh-saini ansh-saini

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: svg re-render on theme change ansh-saini/svgwave
2 participants
@anup-a @ansh-saini