Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svg re-render on theme change #7

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Conversation

ansh-saini
Copy link
Contributor

Fixes #6

  • add waveSvg to state.
  • make use of useEffect to prevent waveSvg re-calculation on theme change.

@vercel
Copy link

vercel bot commented Oct 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/anup-a/svgwave/pkgnknto9
✅ Preview: https://svgwave-git-main.anup-a.vercel.app

@anup-a
Copy link
Owner

anup-a commented Oct 16, 2020

Cool. Nice work 👍

@anup-a anup-a merged commit 29fed9b into anup-a:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React] [Fix] Changing theme should not re-render SVG waves
3 participants