Add tests #1
Merged
Add tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://stackoverflow.com/a/73932581. It seems like importlib-metadata is only required for tests, not production code.
…mplify mocking) the only API calls made in marge-bot are `/projects` (with `simple` undefined) and `/projects/:id`, and both responses always contain the `squash_option` field to limit the scope of validation outside `Project`, convert `squash_option` into an enum
also rename test to reflect wanting vs needing to squash
|
@theipster LGTM, just wanted to understand the pip fix that we have done here in a little bit detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of removing the
squash_enforcedproperty (in order to a) reduce the footprint of theProjectclass; and b) to simplify the mocking), and replaced the "encapsulation" with an enum.Also had to fix some pip dependencies, otherwise the CI test suites wouldn't run at all.