power: handle confirmation dialog #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
reviewed
Feb 23, 2021
There was a problem hiding this comment.
I knew that I had seen this, but wasn't sure if I'd gotten around to making it work.
I think that what I would like to do is just always "watch" responses for a "are you sure" prompt and always send 'y'. My feeling is that the caller of the api wanted done what they wanted done. Its annoying that there is no way to send '--yes-i-mean-it' on the cli.
Does that make sense? can you do something like that?
| @@ -132,7 +132,7 @@ func (cs *Session) SendCmd(ctx context.Context, msg string) (string, error) { | |||
| send = msg | |||
| } else { | |||
| for _, n := range noMoreCmds { | |||
| if fields[0] == n { | |||
| if strings.Contains(fields[0], n) { | |||
|
I put up #10 that always sends confirm to prompts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERIAL-NUMBER /chassis # power cycle
This operation will change the server's power state.
Do you want to continue?[y|N]