-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dispose() does not remove mouse wheel zoom #26
Comments
Using Chrome |
Heh. I just found this comment in the beginning of
|
After debugging the issue in wheel, I have found that the I'm using vue.js, and have to investigate if it's because vue.js is changing the DOM element or if it's in panzoom. What is strange if it's vue.js, is that the other event handlers seems to be removed just fine. |
Found it! wheel is listening to |
…nt element) - fixes anvaka#26
For everyone else with this issue, I have a published a release candidate here: https://www.npmjs.com/package/@dotnetcarpenter/panzoom |
Thanks for catching this and fixing it! This is published as |
@anvaka nice that you added tests! I was wondering how to test this. |
you can run |
I'm using the npm package, 4.3.1 and when calling
instance.dispose()
only pan handlers are removed. I can still zoom with the mouse wheel.The text was updated successfully, but these errors were encountered: