Tests babel independency #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 27, 2016 15:54
- the precise version can depend on setuptools version - we will need to change them, to avoid collisions with a real python dist (Babel) that could also be installed (can come as a Sphinx dependency, for instance) Also silenced all python setup.py preparatory calls from unit tests (cluttered output).
Nowadays, Babel comes as a dependency of Sphinx, and consequently can be installed in the testing virtualenv. The tests need to stop referring to it
and renaming BabelFake as FictiveDist The recipe still has hardcoded dependencies to Babel, (mostly for historical reasons, but we don't want to clean that up right now), so a fake babel posing really as Babel is needed. Had not been spotted in the course of the previous refactor, because the change of name induced a change in cleanups, and I had a Babel.egg-info shadowing the problem.
|
and I have no afterthoughts merging this PR that's purely about tests refactoring (will be useful for subsequent pre-1.9.2 merges) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since last spring, Anybox's buildbot has had test failures on the recipe that were overlooked, because as far as unit tests go, it's been superseded by Travis, and I guess that's why the Travis sequence installs Sphinx only after the tests have passed.
Anyway, the tests did fail if Babel was installed in the virtualenv, now they don't and it's saner.