-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support from Odoo 8.0 to odoo 10.0 #88
Conversation
Thanks for the contribution! |
49083c2
to
4aa8f17
Compare
I get the same error as in the failing tests, when running bin/buildout
|
Sorry, actual error is
which does share the same import problem as https://travis-ci.org/anybox/anybox.recipe.odoo/jobs/163332958#L2703 |
Problem above was caused by inouk.recipe.odoo_cmd which messes up the path with its bin/odoo.py. Sorry for the noise. |
However, on 8.0 I do get
and in this case it is Odoo's own buildout/8.0/parts/odoo/odoo.py which was wisely moved out of the way in 10.0. Can this be solved by juggling paths in the recipe or should this change be made backwards compatible in some way? |
dfe3bb3
to
d417165
Compare
@archetipo, Thanks a lot for this works! After some discussion on #87 the outcomes is that we would prefer maintain only one branch to be able to work from Odoo 8.0 and greater, do you mind to |
c7d0a8b
to
b4396fa
Compare
@StefanRijnhart thanks @petrus-v thanks the differences between 8/9 and 10 are many. imo, it would be easier than the 2.0 versions of anybox are for versions of odoo 10+, and versions of anybox from 1.9.x and minors are for OpenERP 9-8 ... what do you think? |
547ca9a
to
3739f3a
Compare
@@ -1604,7 +1605,7 @@ def finalize_addons_paths(self, check_existence=True): | |||
"please use addons lines with type 'local' " | |||
"instead." % (self.name, opt_key)) | |||
|
|||
base_addons = join(self.openerp_dir, 'openerp', 'addons') | |||
base_addons = join(self.odoo_dir, 'openerp', 'addons') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess here will be:
base_addons = join(self.odoo_dir, 'odoo', 'addons')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrus-v yes, thank you!
b7d15a4
to
249fd0c
Compare
Hum, thinking... Ok, let's try as you say! Depending of how many errors I get while doing my test plan I may change my point of view to automate integration test on our buildbot. if so, I'll create a dedicated branch in this repo called |
Thanks! Odoo8to10
it do not sent properties likes force_demo/status/update_modules so instanciate a we needs to instaniate new registry while installing module. In any odoo version we were already getting a new registry as install step occured while loading the registry.
Using odoo 10.0 RegistryManager.get behavior change it do not sent properties likes force_demo/status/update_modules so instanciate a we needs to instaniate new registry while installing module. In any odoo version we were already getting a new registry as install step occured while loading the registry.
This PR should make compatible this branch with the future of the anybox.recipe.odoo: anybox/anybox.recipe.odoo#88
This PR should make compatible this branch with the future of the anybox.recipe.odoo: anybox/anybox.recipe.odoo#88
I hope this pr gets merged sooner than later. I have to commit the changes in my repo to prevent buildout to fetch from pypi. |
@llacroix my plan is (as mentioned earlier: #88 (comment)) to finalized testing integration and non regressions as soon as possible, to be able to merge this branch in the beginning of January. Regards, |
sorry if this is a dumb question, but will v7 still be supported after this merge? |
@rvalyi, No we don't expect to maintain v7 with this anybox.recipe.odoo (a.r.Odoo)! You should use anybox.recipe.openerp (a.r.Openerp) instead which expect to be used for this purpose! a.r.Openerp may have some feature not implemented that are in a.r.Odoo, if so, you can open an issue on that repo to backport those features from a.r.Odoo and explicitly tell if you start to work on it. |
While testing odoo v8 deployment using this branch I figure out longpolling wasn't working, I'll fix that! |
fix longpolling (gevent) odoo 8 and 9
fix install-all parameter on odoo10 / rename files openerp -> odoo
As announced(https://odoo-community.org/groups/contributors-15/contributors-56573?mode=thread&date_begin=&date_end=) I'm merging this PR. |
#87
I made the following changes to support buildout for odoo 10 .
odoo master , should be merged with this PR.