Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support from Odoo 8.0 to odoo 10.0 #88

Merged
merged 41 commits into from
May 3, 2017
Merged

Conversation

archetipo
Copy link
Contributor

@archetipo archetipo commented Sep 12, 2016

#87

I made the following changes to support buildout for odoo 10 .
odoo master , should be merged with this PR.

@gracinet
Copy link
Contributor

Thanks for the contribution!
That is too much of a change to be released with 1.9.2 (which has been waiting for much too long), and besides, it'll need some adaptation of the unit tests. So, I will consider the PR for next release (don't know yet if that'd be 1.9.3 or 2.0.0)

@archetipo archetipo force-pushed the fix_for_odoo10 branch 2 times, most recently from 49083c2 to 4aa8f17 Compare September 22, 2016 07:58
@StefanRijnhart
Copy link
Contributor

I get the same error as in the failing tests, when running bin/buildout

buildout/10.0/anybox.recipe.odoo/anybox/recipe/odoo/server.py", line 105, in _create_default_config
    from openerp.tools.config import configmanager
ImportError: No module named openerp.tools.config

@StefanRijnhart
Copy link
Contributor

Sorry, actual error is

buildout/10.0/anybox.recipe.odoo/anybox/recipe/odoo/runtime/session.py", line 19, in <module>
    from odoo.tools import config
ImportError: No module named tools

which does share the same import problem as https://travis-ci.org/anybox/anybox.recipe.odoo/jobs/163332958#L2703

@StefanRijnhart
Copy link
Contributor

Problem above was caused by inouk.recipe.odoo_cmd which messes up the path with its bin/odoo.py. Sorry for the noise.

@StefanRijnhart
Copy link
Contributor

However, on 8.0 I do get

buildout/8.0/anybox.recipe.odoo/anybox/recipe/odoo/server.py", line 107, in _create_default_config
    from odoo.tools.config import configmanager
ImportError: No module named tools.config

and in this case it is Odoo's own buildout/8.0/parts/odoo/odoo.py which was wisely moved out of the way in 10.0. Can this be solved by juggling paths in the recipe or should this change be made backwards compatible in some way?

@archetipo archetipo force-pushed the fix_for_odoo10 branch 3 times, most recently from dfe3bb3 to d417165 Compare October 4, 2016 06:37
@petrus-v
Copy link

petrus-v commented Oct 4, 2016

@archetipo, Thanks a lot for this works!
cc @gracinet,

After some discussion on #87 the outcomes is that we would prefer maintain only one branch to be able to work from Odoo 8.0 and greater, do you mind to try/catch odoo import? Do you see any other breaking changes that would be hard to accomplished?

@archetipo archetipo force-pushed the fix_for_odoo10 branch 9 times, most recently from c7d0a8b to b4396fa Compare October 4, 2016 08:26
@archetipo
Copy link
Contributor Author

@StefanRijnhart thanks
Now you can do the buildout for 10

@petrus-v thanks

the differences between 8/9 and 10 are many.
odoo.py has totally changed.
odoo/openerp/base now is odoo/odoo/base
openerp-server became odoo-bin
__openerp__.py the files have become __manifiest__.py

imo, it would be easier than the 2.0 versions of anybox are for versions of odoo 10+, and versions of anybox from 1.9.x and minors are for OpenERP 9-8 ...

what do you think?

@archetipo archetipo force-pushed the fix_for_odoo10 branch 2 times, most recently from 547ca9a to 3739f3a Compare October 4, 2016 08:58
@@ -1604,7 +1605,7 @@ def finalize_addons_paths(self, check_existence=True):
"please use addons lines with type 'local' "
"instead." % (self.name, opt_key))

base_addons = join(self.openerp_dir, 'openerp', 'addons')
base_addons = join(self.odoo_dir, 'openerp', 'addons')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess here will be:

base_addons = join(self.odoo_dir, 'odoo', 'addons')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrus-v yes, thank you!

@archetipo archetipo force-pushed the fix_for_odoo10 branch 5 times, most recently from b7d15a4 to 249fd0c Compare October 4, 2016 12:47
@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage increased (+0.03%) to 86.555% when pulling ccfb0d2 on archetipo:fix_for_odoo10 into 3edb72b on anybox:master.

@petrus-v
Copy link

@archetipo

Hum, thinking... Ok, let's try as you say!

Depending of how many errors I get while doing my test plan I may change my point of view to automate integration test on our buildbot. if so, I'll create a dedicated branch in this repo called dev-odoo_8-9-10_compat (as much persons can get involved to that branch). And I'll give to you and @StefanRijnhart write access to allow you merge PR to that branch. Then I'll do the builders to launch test integration on that branch against odoo 8 / 9 / 10 (that require some change in master branch to set it).

@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-0.3%) to 86.128% when pulling 93d308e on archetipo:fix_for_odoo10 into f14b801 on anybox:master.

Pierre Verkest added 2 commits December 21, 2016 16:02
it do not sent properties likes force_demo/status/update_modules so instanciate
a we needs to instaniate new registry while installing module.

In any odoo version we were already getting a new registry as install step
occured while loading the registry.
Using odoo 10.0 RegistryManager.get behavior change

it do not sent properties likes force_demo/status/update_modules so instanciate
a we needs to instaniate new registry while installing module.

In any odoo version we were already getting a new registry as install step
occured while loading the registry.
@coveralls
Copy link

coveralls commented Dec 21, 2016

Coverage Status

Coverage decreased (-0.3%) to 86.128% when pulling 9573201 on archetipo:fix_for_odoo10 into f14b801 on anybox:master.

@petrus-v petrus-v changed the title Fix for odoo10 Prepare Odoo 8 to odoo 10.0 Dec 21, 2016
@petrus-v petrus-v changed the title Prepare Odoo 8 to odoo 10.0 Support from Odoo 8.0 to odoo 10.0 Dec 21, 2016
petrus-v pushed a commit to anybox/anybox.buildbot.odoo that referenced this pull request Dec 21, 2016
This PR should make compatible this branch with the future of the anybox.recipe.odoo: anybox/anybox.recipe.odoo#88
petrus-v pushed a commit to petrus-v/anybox.buildbot.odoo that referenced this pull request Dec 21, 2016
This PR should make compatible this branch with the future of the anybox.recipe.odoo: anybox/anybox.recipe.odoo#88
@llacroix
Copy link

I hope this pr gets merged sooner than later. I have to commit the changes in my repo to prevent buildout to fetch from pypi.

@petrus-v
Copy link

@llacroix my plan is (as mentioned earlier: #88 (comment)) to finalized testing integration and non regressions as soon as possible, to be able to merge this branch in the beginning of January.

Regards,

@rvalyi
Copy link
Contributor

rvalyi commented Dec 23, 2016

sorry if this is a dumb question, but will v7 still be supported after this merge?

@petrus-v
Copy link

@rvalyi, No we don't expect to maintain v7 with this anybox.recipe.odoo (a.r.Odoo)! You should use anybox.recipe.openerp (a.r.Openerp) instead which expect to be used for this purpose! a.r.Openerp may have some feature not implemented that are in a.r.Odoo, if so, you can open an issue on that repo to backport those features from a.r.Odoo and explicitly tell if you start to work on it.

@petrus-v
Copy link

While testing odoo v8 deployment using this branch I figure out longpolling wasn't working, I'll fix that!

Pierre Verkest added 2 commits December 23, 2016 22:37
@coveralls
Copy link

coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.3%) to 86.179% when pulling fb4cf16 on archetipo:fix_for_odoo10 into f14b801 on anybox:master.

Pierre Verkest added 3 commits December 23, 2016 23:02
@coveralls
Copy link

coveralls commented Jan 3, 2017

Coverage Status

Coverage decreased (-0.3%) to 86.097% when pulling 9e0b6d1 on archetipo:fix_for_odoo10 into f14b801 on anybox:master.

@petrus-v
Copy link

petrus-v commented May 3, 2017

@petrus-v petrus-v merged commit e37e0ac into anybox:master May 3, 2017
rvalyi added a commit to akretion/voodoo-template that referenced this pull request May 16, 2017
@rvalyi rvalyi mentioned this pull request Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants