fix: rethrow cli-ux errors

Author: jdx

package.json

@@ -22,9 +22,9 @@
     "supports-color": "^5.1.0"
   },
   "devDependencies": {
-    "@anycli/tslint": "^0.1.3",
-    "@commitlint/cli": "^6.0.2",
-    "@commitlint/config-conventional": "^6.0.2",
+    "@anycli/tslint": "^0.2.0",
+    "@commitlint/cli": "^6.0.5",
+    "@commitlint/config-conventional": "^6.0.4",
     "@types/ansi-styles": "^2.0.30",
     "@types/chai": "^4.1.2",
     "@types/clean-stack": "^1.3.0",
@@ -37,20 +37,20 @@
     "@types/node": "^9.4.0",
     "@types/node-notifier": "^0.0.28",
     "@types/read-pkg": "^3.0.0",
-    "@types/semver": "^5.4.0",
+    "@types/semver": "^5.5.0",
     "@types/strip-ansi": "^3.0.0",
     "@types/supports-color": "^3.1.0",
     "chai": "^4.1.2",
     "eslint": "^4.16.0",
-    "eslint-config-anycli": "^1.2.1",
-    "fancy-test": "^0.6.4",
+    "eslint-config-anycli": "^1.3.0",
+    "fancy-test": "^0.6.5",
     "husky": "^0.14.3",
     "mocha": "^5.0.0",
     "mocha-junit-reporter": "^1.17.0",
     "nps": "^5.7.1",
     "nps-utils": "^1.5.0",
     "ts-node": "^4.1.0",
-    "typescript": "^2.6.2"
+    "typescript": "^2.7.1"
   },
   "engines": {
     "node": ">=8.0.0"

src/action/base.ts

@@ -19,7 +19,7 @@ const stdmockWrite = {
 }
 
 export class ActionBase {
-  type: ActionType
+  type!: ActionType
   std: 'stdout' | 'stderr' = 'stdout'
   protected stdmocks?: ['stdout' | 'stderr', string[]][]
 

src/action/spinner.ts

@@ -17,7 +17,7 @@ function color(s: string): string {
 export default class SpinnerAction extends ActionBase {
   public type: ActionType = 'spinner'
 
-  spinner: number
+  spinner?: number
   frames: any
   frameIndex: number
 
@@ -41,13 +41,13 @@ export default class SpinnerAction extends ActionBase {
 
   protected _stop(status: string) {
     if (this.task) this.task.status = status
-    clearInterval(this.spinner)
+    if (this.spinner) clearInterval(this.spinner)
     this._render()
     this.output = undefined
   }
 
   protected _pause(icon?: string) {
-    clearInterval(this.spinner)
+    if (this.spinner) clearInterval(this.spinner)
     this._reset()
     if (icon) this._render(` ${icon}`)
     this.output = undefined

src/errors.ts

@@ -100,7 +100,7 @@ function displayError(err: CLIError) {
 }
 
 export class CLIError extends Error {
-  code: string
+  code?: string
   'cli-ux': {
     severity: 'fatal' | 'error' | 'warn'
     exit: number | false
@@ -180,9 +180,14 @@ export default (e: IEventEmitter) => {
 
   return (severity: 'fatal' | 'error' | 'warn') => (input: Error | string, opts: Options = {}) => {
     if (!input) return
+    if (isCLIError(input)) throw input
     const error = new CLIError(input, severity, opts)
     const msg: Message = {type: 'error', severity, error}
     e.emit('output', msg)
     if (error['cli-ux'].exit !== false) throw error
   }
 }
+
+function isCLIError(input: any): input is CLIError {
+  return input['cli-ux']
+}