-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify update script #94
Conversation
You have changed update.sh but it's part of CI process and ubuntu-latest is a platform used by Github actions, so I can't accept this change unfortunately. |
13f8142
to
b374ecb
Compare
Ah, makes sense! I've reverted that bit. Thanks for reviewing! |
anyproto-heart artifacts do not need github authentication to download. This might be left over from before this project was public. Anonymous downloading is safer for developers. Make "ubuntu-latest" the default platform.
b374ecb
to
772a479
Compare
Updated github actions with the update.sh argument changes. |
Oh nice - I also wanted to ask about the Auth not needed anymore in the update.sh 🎉 @cmars did you had no issues while trying to |
As it runs two times for macos and linux it basically creates two folders darwin-amd and darwin-arm which are then copied to dist by electronn hook. So no, update.sh doesnt need this step, if you want update.sh to work correctly you can just fix README.md, imo, which adds |
looks better, I will check once again and merge when I will be able to merge, right now my colleague is doing some licensing magic =) |
recheck |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
anyproto-heart artifacts do not need github authentication to download. This might be left over from before this project was public. Anonymous downloading is safer for developers and preserves a bit more privacy.
Make "ubuntu-latest" the default platform. A bit opinionated, but linux is generally a safe default for CI and Docker, so might be reasonable. I can yoink this particular if it's too controversial.
Thanks!