Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uint128T for add function in FMA and Add #46

Merged
merged 6 commits into from
May 27, 2019

Conversation

joshcarp
Copy link
Contributor

Allows for cleaner rounding and for more rounding attributes to be added.
FMA function and Add function use intermediate add function.

decimal64decParts.go Outdated Show resolved Hide resolved
decimal64math.go Show resolved Hide resolved
uint128.go Show resolved Hide resolved
MichaelDao
MichaelDao previously approved these changes May 26, 2019
Copy link
Contributor

@MichaelDao MichaelDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@MichaelDao MichaelDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git log cleaned up, lgtm

@joshcarp joshcarp merged commit e6f2e90 into anz-bank:master May 27, 2019
@joshcarp joshcarp deleted the 128Add branch June 10, 2019 09:03
joshcarp added a commit to joshcarp/decimal that referenced this pull request Sep 1, 2019
* Fix Add Half up rounding

* Functionise Add128

* Fix uint128T numdecimaldigit bug

* Change significand to be 128 bits

* Seperate matchscales128 and add128

* Add new file for supporting decParts arithmetic functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants