Fix Quotient function to pass dectests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshcarp
commented
Jun 11, 2019
joshcarp
commented
- Change Quotient method to pass dectests
- Pass half up and half even rounding
- Use type of binary rounding to keep track of remainders
MichaelDao
suggested changes
Jun 11, 2019
joshcarp
commented
Jun 17, 2019
| return infinities[sign] | ||
| dp.matchSignificandDigits(&ep) | ||
| ans.exp = dp.exp - ep.exp | ||
| for { |
There was a problem hiding this comment.
So the idea is that there's no way of knowing how much precision the answer will take up in the final answer Without using binary long division. Here we are doing long division, but we keep adjusting the exponent (and the significand) by multiplying it by 10 until we get to the point where we've filled up our precision, then the remainder is rounded. Other methods of division cannot be used because truncation occurs without notice
MichaelDao
approved these changes
Jun 18, 2019
Closed
joshcarp
added a commit
to joshcarp/decimal
that referenced
this pull request
Sep 1, 2019
* Add matchsignificand size function * Add first Implementation of Quo * Quo function with some rounding * Add context for quo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.