Add CI #11
Comments
Merged
|
CI is in place now. |
anzopensource
pushed a commit
that referenced
this issue
Feb 15, 2021
* health: Create OpenAPI spec for default health endpoints Add swagger spec to describe default health package endpoints in standardised format: /readyz /healthz /version Issue: #52 * github: Fix version bump action label Update version bump action label from "build" (the GitHub action's job) to something more meaningful and easier to identify in branch protection settings. * Jack/pkg update (#71) * Add downstream test job to workflow (#1) * Contextual clock package (#2) * Context-driven envvar package (#3) * Jack/speed up GitHub mod (#4) Speeds up the module package when in Github mode by ~50% Changes - Fix bug in caching, which was causing cached files to not be found - Run Github API calls concurrently, rather than synchronously - Add benchmark tests * Run in parallel name old time/op new time/op delta GetCacheRef-16 696ms ± 0% 505ms ± 0% ~ (p=1.000 n=1+1) RetrieveGitHubModeUncached-16 1.65s ± 0% 1.05s ± 0% ~ (p=1.000 n=1+1) * Fix bug in cache dir Previously the cache dir was getting added twice as the mod.dir already contains the cache directory. Therefore, none of the cached files were found and were being re-downloaded every time * Add benchmark test and `make bench` * Receive cache ref with channels * Move integration tests under integration build tag (#5) Moves integration tests into separate files so that they don't get run in CI. This speeds up the `make test` command significantly Integration tests can be run with the `make integration` target Co-authored-by: Oliver <Oliver.Lade@anz.com> Co-authored-by: Marcelo Cantos <anzdaddy@users.noreply.github.com> * health: Fix data race in health readiness access Make the readiness value a uint32 and read/write it with the `atomic` package functions `LoadUint32` and `StoreUint32`, instead of unprotected access to a boolean. The health readiness value is read and written from different goroutines mostly. This was explicitly done without locking as the readiness value was a single bit and nothing that needed to be synchronised. That's still bad. At least, it should be an atomic - no data should be read/written concurrently without an atomic or a mutex or more. Add a test case that fails the race detector if readiness is not properly protected. * TimeTravel.After won't change offset till after channel read Replace Jump methods with NewTimeTravelStartingAt. Quieten linter * add new logging library This is a major change that adds an alternative logging API. This is to facilitate using zerolog as the underlying log package instead of logrus. Changes include * new logging API, based around zerolog and json logging * Log context now acts as a go-between for logging and context * Added Error as a separate logging level * pkg/logging - backfill unit test coverage * pkg/logging tests - refactor to appease linter * .golangci - disable "dogsled" lint rule * Includes FieldsFrom method in log The FieldsFrom method is the reverse of Onto (that puts fields into the context). Co-authored-by: Julia Ogris <julia.ogris@gmail.com> Co-authored-by: Jack Zheng <j.zheng@live.com.au> Co-authored-by: Oliver <Oliver.Lade@anz.com> Co-authored-by: Marcelo Cantos <anzdaddy@users.noreply.github.com> Co-authored-by: Cam Hutchison <Cameron.Hutchison@anz.com> Co-authored-by: Ashwin Sajiv <sajivashwin@gmail.com> Co-authored-by: Ashwin Sajiv <37055705+ashwinsajiv@users.noreply.github.com> Co-authored-by: anzboi <daniel.cantos@anz.com> Co-authored-by: Reuben Fletcher-Costin <reuben.fletcher-costin@anz.com> Co-authored-by: Andrew Emery <59628488+andrewemeryanz@users.noreply.github.com> Co-authored-by: Andrew Emery <andrew.emery@anz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All the OS CI for testing and godoc generation
It would be nice to have diffing tool for the godoc to see the impact in documentation
The text was updated successfully, but these errors were encountered: