Show staked vs nonstaked packets sent down/throttled #600
Conversation
lijunwangs
requested review from
ryleung-solana
and removed request for
ryleung-solana
lijunwangs
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 851 851
Lines 230149 230163 +14
=======================================
+ Hits 188438 188467 +29
+ Misses 41711 41696 -15 |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* Show staked vs nonstaked packets sent down * add metrics on throttled staked vs non-staked (cherry picked from commit b443cfb) # Conflicts: # streamer/src/quic.rs
* Show staked vs nonstaked packets sent down * add metrics on throttled staked vs non-staked (cherry picked from commit b443cfb) # Conflicts: # streamer/src/quic.rs
| pub(crate) total_staked_packets_sent_for_batching: AtomicUsize, | ||
| pub(crate) total_unstaked_packets_sent_for_batching: AtomicUsize, | ||
| pub(crate) throttled_staked_streams: AtomicUsize, | ||
| pub(crate) throttled_unstaked_streams: AtomicUsize, |
There was a problem hiding this comment.
Change looks good to me; should we deprecate total_packets_sent_for_batching and throttled_streams; both of these can now be implied by adding unstaked + staked
There was a problem hiding this comment.
I think it is okay to leave it alone for convenience in doing Grafana.
… of #600) (#614) * Show staked vs nonstaked packets sent down/throttled (#600) * Show staked vs nonstaked packets sent down * add metrics on throttled staked vs non-staked (cherry picked from commit b443cfb) # Conflicts: # streamer/src/quic.rs * fix merge conflicts --------- Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com> Co-authored-by: HaoranYi <haoran.yi@solana.com>
… of #600) (#613) * Show staked vs nonstaked packets sent down/throttled (#600) * Show staked vs nonstaked packets sent down * add metrics on throttled staked vs non-staked (cherry picked from commit b443cfb) # Conflicts: # streamer/src/quic.rs * fix merge conflicts --------- Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com> Co-authored-by: HaoranYi <haoran.yi@solana.com>
Problem
The current metrics cannot tell what are the portions of packets sent down and throttled from staked vs non-staked.
Summary of Changes
Add two metrics in streamer:
staked_packets_sent_for_batching
unstaked_packets_sent_for_batching
throttled_unstaked_streams
throttled_staked_streams
Fixes #