Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: Show staked vs nonstaked packets sent down/throttled (backport of #600) #613

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 5, 2024

Problem

The current metrics cannot tell what are the portions of packets sent down and throttled from staked vs non-staked.

Summary of Changes

Add two metrics in streamer:

staked_packets_sent_for_batching
unstaked_packets_sent_for_batching
throttled_unstaked_streams
throttled_staked_streams

Fixes #


This is an automatic backport of pull request #600 done by [Mergify](https://mergify.com).

* Show staked vs nonstaked packets sent down

* add metrics on throttled staked vs non-staked

(cherry picked from commit b443cfb)

# Conflicts:
#	streamer/src/quic.rs
@mergify mergify bot added the conflicts label Apr 5, 2024
Copy link
Author

mergify bot commented Apr 5, 2024

Cherry-pick of b443cfb has failed:

On branch mergify/bp/v1.17/pr-600
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit b443cfb0c7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   streamer/src/nonblocking/quic.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   streamer/src/quic.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (2199f6e) to head (429e15b).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17     #613     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219284   219298     +14     
=========================================
- Hits       179060   179034     -26     
- Misses      40224    40264     +40     

Copy link

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Looks good to me. Please get approval from backport/release owners before merging.

Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-nelson t-nelson merged commit 7cee876 into v1.17 Apr 11, 2024
33 checks passed
@t-nelson t-nelson deleted the mergify/bp/v1.17/pr-600 branch April 11, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants