-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.17: quic: delay calling set_max_concurrent_uni_streams/set_receive_window (backport of #904) #967
Conversation
Cherry-pick of 2770424 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alessandrod can you address the merge conflict?
dea6762
to
6f5ea0f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #967 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 806 806
Lines 219335 219335
=======================================
+ Hits 179047 179104 +57
+ Misses 40288 40231 -57 |
6f5ea0f
to
4a8a663
Compare
…#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs
4a8a663
to
afba8f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr was created before the bp enforcing rules kicked in so the groups were not added properly, I'm approving since we've got the other 2 approvals
merge me! |
Delay calling connection.set_max_concurrent_uni_streams() and connection.set_receive_window() to when we know we've accepted the connection. Avoids a short window where the peer could start transmitting even if we're going to drop the connection, and avoids taking the connection mutex and waking a task.
This is an automatic backport of pull request #904 done by Mergify.