Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/citation n constraints#5667 #91

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

HavierD
Copy link
Contributor

@HavierD HavierD commented Jul 10, 2024

No description provided.

@HavierD HavierD marked this pull request as draft July 11, 2024 23:38
@HavierD HavierD marked this pull request as ready for review July 11, 2024 23:54
@HavierD
Copy link
Contributor Author

HavierD commented Jul 12, 2024

issue about the suggested citation has raised here: https://github.com/aodn/backlog/issues/5737

Copy link
Contributor

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* @param cons the constraint
* @return true if the constraint is like a suggested citation
*/
private static boolean isSuggestedCitation(String cons) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Leave a to do comments
  2. Always return false
  3. Explain in more detail of where we see this, your conversation with Nat
  4. Raise ticket to implement it later and copy the issue here, we need discuss with Steve.

@HavierD HavierD merged commit 883d942 into main Jul 12, 2024
2 checks passed
@HavierD HavierD deleted the feature/citation-n-constraints#5667 branch July 12, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants