Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type enhancing #655

Closed
wants to merge 0 commits into from
Closed

Type enhancing #655

wants to merge 0 commits into from

Conversation

Cyberghxst
Copy link
Contributor

Description

Hi, it's me again.
This PR introduces some brief changes in aoi.js typings and adds some others.
It also adds a JSDoc comment to every aoi.js function to make everything typed as possible:

/**
 * @param {import("..").Data} d
 */
module.exports = (d) => {
   // ...
}

I also added @discordjs/ws dependency as it is required in package source and some machines like mine do not have installed globally.

Type of change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

@Faf4a Faf4a requested review from USERSATOSHI and Leref and removed request for USERSATOSHI September 17, 2024 06:48
@Faf4a Faf4a added state: pending Approval must be done first, to be accepted. aoi.js this issue/Pr is related to aoi.js labels Sep 17, 2024
@USERSATOSHI
Copy link
Member

Hi! I think we can switch djs/ws from dep to dev dep as djs has it in its dep so we dont really need it

@Cyberghxst
Copy link
Contributor Author

Cyberghxst commented Sep 17, 2024

Hi! I think we can switch djs/ws from dep to dev dep as djs has it in its dep so we dont really need it

Okay, done.

@Faf4a
Copy link
Member

Faf4a commented Sep 23, 2024

Sorry about the conflicts but please solve them if you're still interested in contributing.

@Faf4a Faf4a added state: blocked PR needs changes before further review and removed state: pending Approval must be done first, to be accepted. labels Sep 23, 2024
@Cyberghxst Cyberghxst closed this Sep 24, 2024
@Cyberghxst Cyberghxst mentioned this pull request Sep 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aoi.js this issue/Pr is related to aoi.js state: blocked PR needs changes before further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants