Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ventura issue rendering custom document icons (Fixed in macOS Ventura 13.4) #1177

Open
xzhouzhou758 opened this issue Nov 5, 2022 · 36 comments

Comments

@xzhouzhou758
Copy link

xzhouzhou758 commented Nov 5, 2022

👉 Fixed in macOS Ventura 13.4

  • Keka version: [ 1.2.57 (5068)]
  • macOS version: [macOS 13.0 (22A380)]

The icon is displayed normally in the download folder, but the icon is displayed abnormally in the download of the dock

截屏2022-11-05 18 41 34

截屏2022-11-05 18 41 23

@xzhouzhou758 xzhouzhou758 changed the title zip icon abnormally [BUG] [GUI] zip icon abnormally Nov 5, 2022
@desmortum
Copy link

Yeah. Same thing. In Finder looks good. In Dock looks generic in folders like Downloads or if you pin file to Dock. Also, looks generic in Chrome downloads. Seems like something changed in Ventura.

Screenshot 2022-11-05 at 17 58 12

Screenshot 2022-11-05 at 17 58 26

Screenshot 2022-11-05 at 17 58 01

@desmortum
Copy link

Same for *.tar. I guess all formats are affected. I tried cleaning icon cache and doing clean reinstall of Keka. When you remove Keka, original archiver icons are back in Dock and Chrome. When you install Keka, they're generic again.

@aonez
Copy link
Owner

aonez commented Nov 5, 2022

Seems it’s #453 again. Will check if I can replicate this.

@aonez aonez added this to the Apple's milestone Nov 5, 2022
@desmortum
Copy link

desmortum commented Nov 5, 2022

Unlike in #453, icon is completely blank. As if all apps except Finder cannot get icon for formats associated with Keka at all.

@desmortum
Copy link

I've done some experimentation and it seems no privacy permission changes help. What I did find is that other built-in and third-party apps have their associated type icons shown properly. For example Visual Studio *.sln file works fine.

Screenshot 2022-11-05 at 20 06 05

@desmortum
Copy link

Found few discussions on Apple site. It seems Adobe PDF is affected too. Hope you can find a way to fix it.

@desmortum
Copy link

@aonez, any luck replicating?

@aonez aonez changed the title zip icon abnormally Ventura issue with icons Nov 9, 2022
@aonez aonez changed the title Ventura issue with icons Ventura issue with icons in the Dock Nov 9, 2022
@aonez
Copy link
Owner

aonez commented Nov 9, 2022

Tried with one of the first macOS Ventura betas. While it does not show a generic white document icon, the Dock representations show the macOS zip white icons even if Keka is the default handler. As you can see in the screenshots, same as in #453, only compressed files already recognized by macOS have this issue. Brotli, LZIP and ZSTD do not present this issue.

Will install and try with the current Ventura release, but most probably this should be fixed in Apple's end. I will report it myself after trying with the current version.

This should be reported using the Feedback Assistant: https://developer.apple.com/bug-reporting

Screenshot 2022-11-09 at 17 13 41

Screenshot 2022-11-09 at 17 13 15

@desmortum
Copy link

Yeah, Brotli is okay in release version of Ventura.

Screenshot 2022-11-09 at 17 51 23

@aonez
Copy link
Owner

aonez commented Nov 10, 2022

So tried with macOS 13.1 beta and it shows the white icons as you reported. Even when extracting with Keka they show white, same as in Chrome.

This is the offending API:

[NSWorkspace.sharedWorkspace iconForFile:(NSString *)];

I'm reporting this to Apple right away, but if #453 meant something, this might not be fixed until macOS 14 or later. Fingers crossed they fix this before that.

Screenshot 2022-11-10 at 10 30 28
Screenshot 2022-11-10 at 10 40 27

@aonez
Copy link
Owner

aonez commented Nov 10, 2022

Also note this will probably affect all apps that override macOS defined icons, such as video apps (VLC or INA).

@aonez aonez changed the title Ventura issue with icons in the Dock Ventura issue rendering custom document icons Nov 10, 2022
@aonez
Copy link
Owner

aonez commented Nov 10, 2022

Already reported to Apple:

Title: Third party document icons not displayed properly on macOS 13
Area: AppKit
Issue: Incorrect/Unexpected behaviour

Third party applications that define icons for macOS recognized document types are not displayed properly on macOS 13.

To reproduce:

- Download Keka or another app that defines icons for system known formats (like ZIP, MOV)
- Be sure to set that application as the default handler for the document type (ZIP, MOV).
- Restart the system if needed to refresh icon caches.
- The custom icons will show properly in the Finder but will show blank where they’re displayed using [NSWorkspace.sharedWorkspace iconForFile:(NSString *)].

You can check this adding a folder with the offending files inside to the Dock, as shown in the screenshots.

Additional info:

This was reported by three users already (more to come) and reproduced by me.
https://github.com/aonez/Keka/issues/1177

All apps that use the NSWorkspace iconForFile: API (and variations of it) will be affected by this issue.
https://developer.apple.com/documentation/appkit/nsworkspace/1528158-iconforfile

macOS 13.0 Beta 22A5286j displayed the macOS icons, instead of the custom ones.
macOS 13.0 22A380 and later (tested macOS 13.1 Beta 22C5044e as well) display blank icons.

Please report it too if you are affected by this issue and want it to be fixed as soon as possible.

@desmortum
Copy link

Reported as well.

Repository owner deleted a comment from welaxxx Nov 14, 2022
@desmortum
Copy link

@aonez, 13.1 beta 3 is out. Maybe if you have time and partition to check it out give it a shot.

@aonez
Copy link
Owner

aonez commented Nov 16, 2022

There's no mention to this in the release notes, but I'll check it anyway.

@aonez
Copy link
Owner

aonez commented Nov 16, 2022

Same same...

Screenshot 2022-11-16 at 21 15 23

@desmortum
Copy link

Thanks for checking.

@aonez
Copy link
Owner

aonez commented Dec 2, 2022

@pan93412
Copy link
Contributor

pan93412 commented Dec 2, 2022

Reported as well! Hope Apple can take care of their products' issues. I have reported for at least 3 issues related to macOS 13 😢

截圖 2022-12-02 上午9 47 14

@aonez
Copy link
Owner

aonez commented Dec 16, 2022

Ventura 13.2 Beta still has the issue, as expected.

image

@pan93412
Copy link
Contributor

Ventura 13.2 Release still has the issue :(

image

@melyux
Copy link

melyux commented Feb 4, 2023

Reported too. But does Apple even take action on any feedback items? It's like a black hole. I've probably reported 20+ things in the past but they were never fixed unless Apple decided to revamp the entire application and fixed it by chance several years later.

image

@codebysandwich
Copy link

Ventura 13.2.1 Release still has the issue :(, alfred affected too.

@despecial
Copy link

Ventura 13.3 still does not fix this :(

@JustCrazyer
Copy link

Ventura 13.3.1 still does not fix this :(

@aonez
Copy link
Owner

aonez commented May 9, 2023

As reported by @pan93412 we got some news in the Feedback Assistant that reads:

Recent Similar Reports: Less than 10
Resolution: Potential fix identified - For a future OS update

So thanks to @pan93412 for the tip and to all who reported this. Expect the fix in macOS 14, as expected 🙃

@animusastralis
Copy link

Finally! Ventura 13.4 got it fixed

@aonez
Copy link
Owner

aonez commented May 19, 2023

I'm still seeing the issue on Ventura 13.4 (22F66)

Screenshot 2023-05-19 at 13 07 26

@desmortum
Copy link

desmortum commented May 19, 2023

For me it's also fixed.
Screenshot 2023-05-19 at 13 09 51

Screenshot 2023-05-19 at 13 09 57 Screenshot 2023-05-19 at 13 10 08 Screenshot 2023-05-19 at 13 09 43

@desmortum
Copy link

@aonez, try rebooting or doing "killall Dock"

@aonez
Copy link
Owner

aonez commented May 19, 2023

@desmortum yep already did a restart, cold start and relaunched Finder... But also in Safari the bug persists.

Screenshot 2023-05-19 at 13 14 00

@animusastralis are you on an Intel too?

@desmortum
Copy link

@aonez, maybe OS icon cache?

@aonez
Copy link
Owner

aonez commented May 19, 2023

Yeah probably, just updated an ARM VM and it's indeed fixed 👏🏼

@aonez aonez added the fixed label May 19, 2023
@animusastralis
Copy link

animusastralis commented May 19, 2023

@aonez no, I'm on M2 MacBook Pro. I didn't notice it right away and did a couple of reboots for other reasons

@aonez aonez changed the title Ventura issue rendering custom document icons Ventura issue rendering custom document icons (Fixed in macOS Ventura 13.4) May 19, 2023
@pan93412
Copy link
Contributor

Before clearing cache, it did still not work:

image

After clearing the cache with a Gist script, it works now:

image

@aonez

@gingerbeardman
Copy link
Contributor

Congrats everybody! what a long journey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants