Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new Arabic Localization ar.xliff #1329

Closed
naqqo6i opened this issue Sep 14, 2023 · 16 comments
Closed

Create a new Arabic Localization ar.xliff #1329

naqqo6i opened this issue Sep 14, 2023 · 16 comments

Comments

@naqqo6i
Copy link

naqqo6i commented Sep 14, 2023

ar.xliff.zip

I don't if I am using the latest version of the translation file or not, but I added the Arabic translation.

Let me know if you need any modification.

Thanks,
Thamer

@aonez aonez added this to the iOS milestone Sep 15, 2023
@aonez
Copy link
Owner

aonez commented Sep 15, 2023

Thanks a lot @naqqo6i! This will be the first translation in Arabic for Keka, not even the macOS version has this translation.

Will check it and let you know how it goes.

aonez added a commit that referenced this issue Sep 15, 2023
@aonez aonez closed this as completed in 6725fc3 Sep 16, 2023
@aonez aonez modified the milestones: iOS, iOS-1.2.1 Sep 16, 2023
aonez added a commit that referenced this issue Sep 16, 2023
@aonez
Copy link
Owner

aonez commented Sep 16, 2023

Thanks again @naqqo6i. I've already pushed this one to TestFlight, build 865. So you can check it out.

I'll need to fix the format selector in the compression view, since it goes left-right and it's not working properly on right-left layout.

By the way this is not properly translated:

<trans-unit id="ARCHIVE_DEFAULT_NAME" xml:space="preserve">
<source>Archive</source>
<target>Archive</target>
<note>إسم ملف الضغط الإفتراضي.</note>

You've translated the note (should be "Default compression file name."). The note is only for translators to understand what the string should mean. You Archive is what should be translated.

@naqqo6i
Copy link
Author

naqqo6i commented Sep 16, 2023 via email

@aonez
Copy link
Owner

aonez commented Sep 16, 2023 via email

@naqqo6i
Copy link
Author

naqqo6i commented Sep 16, 2023 via email

@aonez
Copy link
Owner

aonez commented Sep 18, 2023

Your email address was removed on Github. Anyway, I've just pushed another build with the format selector fixed for right to left layouts (like Arabic). You should see the new build 883. If still don't see it, send me your mail address to info@keka.io.

Thanks again Thamer 🙌🏼

@naqqo6i
Copy link
Author

naqqo6i commented Sep 18, 2023 via email

@aonez
Copy link
Owner

aonez commented Sep 18, 2023 via email

@naqqo6i
Copy link
Author

naqqo6i commented Sep 19, 2023 via email

@aonez
Copy link
Owner

aonez commented Sep 20, 2023

Done.

Did you added some modifications? Where are the files?

The Settings title in the Setting screen doesnot change even if the parameter is there. Can you check that.

Not sure where you mean. I see the Settings tittle localized:

image

Also, can you please add my user : @mr_thamer instead of @naqqo6i.

This is your Twitter handle?

@aonez
Copy link
Owner

aonez commented Sep 20, 2023

Note that if you reply via mail instead of in the website (#1329) some of the information/files you send will be filtered by Github.

@naqqo6i
Copy link
Author

naqqo6i commented Sep 20, 2023 via email

@aonez
Copy link
Owner

aonez commented Sep 20, 2023

Yes, I downloaded from the github then I modified the attached file.

I did not received it. If you want to send me via mail please send it to info@keka.io.
Otherwise go to the ticket #1329 and attach the file there.

Thanks again Thamer

@aonez
Copy link
Owner

aonez commented Sep 26, 2023

@naqqo6i just released 1.2.1 with your translation! Should I refer to Arabic with he 🇦🇪 or the 🇸🇦 flag?

@naqqo6i
Copy link
Author

naqqo6i commented Sep 26, 2023 via email

@naqqo6i
Copy link
Author

naqqo6i commented Sep 26, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants